Use rmdir to delete pkgbuild directories on windows

tools/testing/dart/test_suite.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for enumerating and preparing tests.
  *
  * This library includes:
  *
  * - Creating tests by listing all the Dart files in certain directories,
@@ skipping 1933 matching lines @@
       args = [source, dest, '/e', '/i'];
     }
     return Process.run(executable, args).then((ProcessResult result) {
       if (result.exitCode != 0) {
         throw new Exception("Failed to execute '$executable "
             "${args.join(' ')}'.");
       }
     });
   }
 
+  static Future deleteDirectory(String path) {
+    // We are seeing issues with long path names on windows when
+    // deleting them. Use the system tools to delete our long paths.
+    if (Platform.operatingSystem == 'windows') {

[Bill Hesse, 2014/08/11 09:24:13]

Can we include a bug number or TODO about making delete(recursive: true) work
flawlessly on Windows, and removing this?

[ricow1, 2014/08/11 09:37:30]

Done

+      var native_path = new Path(path).toNativePath();
+      // Running this in a shell sucks, but rmdir is not part of the standard
+      // path.
+      return Process.run('rmdir', ['/s', '/q', native_path], runInShell: true)
+        .then((ProcessResult result) {
+          if (result.exitCode != 0) {
+            throw new Exception('Can\'t delete path $native_path. '

[Bill Hesse, 2014/08/11 09:24:13]

Maybe you should check the length of the path before suggesting it is the
problem.  It will be bad if people get this message for C:\temp\foo.  Beacuse
ends not in t.

[ricow1, 2014/08/11 09:37:30]

That will actually throw an ProcessException, we will not get in here

+                                'This may be becaust the path is to long');
+          }  
+        });
+    } else {
+      var dir = new io.Directory(path);
+      return dir.delete(recursive: true);
+    }
+  }
+
   static Path debugLogfile() {
     return new Path(".debug.log");
   }
 
   static String flakyFileName() {
     // If a flaky test did fail, infos about it (i.e. test name, stdin, stdout)
     // will be written to this file. This is useful for the debugging of
     // flaky tests.
     // When running on a built bot, the file can be made visible in the
     // waterfall UI.
@@ skipping 297 matching lines @@
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout
  * $compileErrorSkip tests are skipped on browsers due to compile-time error
 """;
     print(report);
   }
 }