tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py - Issue 461043003: Implement --browser=<perf trybot>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py

Issue 461043003: Implement --browser=<perf trybot> (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Changed patch title to something that passes presubmit Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder_unittest.py ('k') | tools/telemetry/telemetry/core/browser_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py

diff --git a/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py b/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py

index c89594c9788f423f0d979a214fe622c752801e3f..0520a3820c7f81b44b909a1ee7c386919f2dd878 100644

--- a/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py

+++ b/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py

@@ -30,7 +30,7 @@ class PossibleWebDriverBrowser(possible_browser.PossibleBrowser):

target_os = sys.platform.lower()

super(PossibleWebDriverBrowser, self).__init__(browser_type, target_os,

finder_options, False)

- assert browser_type in FindAllBrowserTypes(), \

+ assert browser_type in FindAllBrowserTypes(finder_options), \

('Please add %s to webdriver_desktop_browser_finder.FindAllBrowserTypes'

% browser_type)

@@ -81,7 +81,7 @@ class PossibleDesktopIE(PossibleWebDriverBrowser):

def SelectDefaultBrowser(_):

return None

-def FindAllBrowserTypes():

+def FindAllBrowserTypes(_):

if webdriver:

return [

'internet-explorer',