Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: ui/webui/resources/js/cr.js

Issue 460163002: Handle property definition by {cr|Object}.defineProperty() in compiler pass (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@C_compiler_pass
Patch Set: rebase onto master Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/closure_compiler/runner/test/com/google/javascript/jscomp/ChromePassTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/webui/resources/js/cr.js
diff --git a/ui/webui/resources/js/cr.js b/ui/webui/resources/js/cr.js
index dbcbb828a5621ad664f3b685529cd16774b5ee8f..757039d56596b5b61a861de54df4c0f51a530d1c 100644
--- a/ui/webui/resources/js/cr.js
+++ b/ui/webui/resources/js/cr.js
@@ -75,17 +75,20 @@ var cr = function() {
/**
* Plain old JS property where the backing data is stored as a "private"
* field on the object.
+ * Use for properties of any type. Type will not be checked.
*/
JS: 'js',
/**
* The property backing data is stored as an attribute on an element.
+ * Use only for properties of type {string}.
*/
ATTR: 'attr',
/**
* The property backing data is stored as an attribute on an element. If the
* element has the attribute then the value is true.
+ * Use only for properties of type {boolean}.
*/
BOOL_ATTR: 'boolAttr'
};
« no previous file with comments | « third_party/closure_compiler/runner/test/com/google/javascript/jscomp/ChromePassTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698