Chromium Code Reviews Chromium Code Reviews
Issue 459953002:
Migrate geolocation permissions to the new common permission class. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 2058277bf07c3dc7732ce20a02137b9f00f62708..90f324939196da5118a4744e9ef9e1fb95ffc08a 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -9238,12 +9238,18 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| <histogram name="Geolocation.InfoBarDelegate.Event" |
| enum="GeolocationInfoBarDelegateEvent"> |
| + <obsolete> |
| + Deprecated 9/2014, and replaced by PermissionActions. |
| + </obsolete> |
| <owner>mvanouwerkerk@chromium.org</owner> |
| <summary>Events in GeolocationInfoBarDelegate.</summary> |
| </histogram> |
| <histogram name="Geolocation.InfoBarDelegateAndroid.Event" |
| enum="GeolocationInfoBarDelegateAndroidEvent"> |
| + <obsolete> |
| + Deprecated 8/2014, and replaced by PermissionActions. |
|
Michael van Ouwerkerk
2014/09/22 17:02:56
9/2014
Miguel Garcia
2014/09/24 11:04:44
Done.
Miguel Garcia
2014/09/24 11:04:44
Done.
|
| + </obsolete> |
| <owner>mvanouwerkerk@chromium.org</owner> |
| <summary>Events in GeolocationInfoBarDelegateAndroid.</summary> |
| </histogram> |
| @@ -43356,6 +43362,9 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </enum> |
| <enum name="GeolocationInfoBarDelegateEvent" type="int"> |
|
Michael van Ouwerkerk
2014/09/22 17:02:56
Please also deprecate the GeolocationInfoBarDelega
Miguel Garcia
2014/09/24 11:04:44
Done.
|
| + <obsolete> |
| + Deprecated 8/2014, and replaced by PermissionAction. |
|
Michael van Ouwerkerk
2014/09/22 17:02:56
9/2014
Miguel Garcia
2014/09/24 11:04:44
Done.
|
| + </obsolete> |
| <int value="0" label="The bar was created"/> |
| <int value="1" label="User allowed use of geolocation"/> |
| <int value="2" label="User denied use of geolocation"/> |
| @@ -55096,6 +55105,7 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <suffix name="MidiSysEx" label="Midi SysEx permsision actions"/> |
| <suffix name="PushMessaging" label="Push messaging permission actions"/> |
| <suffix name="Notifications" label="Notification permission actions"/> |
| + <suffix name="Geolocation" label="Geolocation permission actions"/> |
| <affected-histogram name="ContentSettings.PermissionActions"/> |
| </histogram_suffixes> |
