Move more Sockets browser tests into appshell tests.

extensions/browser/api/socket/socket_apitest.cc

Index: extensions/browser/api/socket/socket_apitest.cc
diff --git a/extensions/browser/api/socket/socket_apitest.cc b/extensions/browser/api/socket/socket_apitest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..58fd6024cc36123a90e4315261e24aaea43552b7
--- /dev/null
+++ b/extensions/browser/api/socket/socket_apitest.cc
@@ -0,0 +1,73 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "extensions/browser/api/dns/host_resolver_wrapper.h"
+#include "extensions/browser/api/dns/mock_host_resolver_creator.h"
+#include "extensions/browser/api/socket/socket_api.h"
+#include "extensions/browser/api_test_utils.h"
+#include "extensions/common/extension.h"
+#include "extensions/common/test_util.h"
+#include "extensions/shell/test/shell_test.h"
+
+using extensions::api_test_utils::RunFunctionAndReturnSingleResult;
+
+namespace extensions {
+
+class SocketApiTest : public AppShellTest {};
+
+IN_PROC_BROWSER_TEST_F(SocketApiTest, SocketUDPCreateGood) {
+  scoped_refptr<extensions::SocketCreateFunction> socket_create_function(
+      new extensions::SocketCreateFunction());
+  scoped_refptr<Extension> empty_extension = test_util::CreateEmptyExtension();
+
+  socket_create_function->set_extension(empty_extension.get());
+  socket_create_function->set_has_callback(true);
+
+  scoped_ptr<base::Value> result(RunFunctionAndReturnSingleResult(
+      socket_create_function.get(), "[\"udp\"]", browser_context()));
+  ASSERT_EQ(base::Value::TYPE_DICTIONARY, result->GetType());
+  base::DictionaryValue* value =
+      static_cast<base::DictionaryValue*>(result.get());

[Yoyo Zhou, 2014/08/11 23:32:57]

No need to static cast.
DictionaryValue* value = NULL;
ASSERT_TRUE(result->GetAsDictionary(&value));

[Daniel Nishi, 2014/08/11 23:40:45]

Done.

+  int socket_id = -1;
+  EXPECT_TRUE(value->GetInteger("socketId", &socket_id));
+  EXPECT_GT(socket_id, 0);
+}
+
+IN_PROC_BROWSER_TEST_F(SocketApiTest, SocketTCPCreateGood) {
+  scoped_refptr<extensions::SocketCreateFunction> socket_create_function(
+      new extensions::SocketCreateFunction());
+  scoped_refptr<Extension> empty_extension = test_util::CreateEmptyExtension();
+
+  socket_create_function->set_extension(empty_extension.get());
+  socket_create_function->set_has_callback(true);
+
+  scoped_ptr<base::Value> result(RunFunctionAndReturnSingleResult(
+      socket_create_function.get(), "[\"tcp\"]", browser_context()));
+  ASSERT_EQ(base::Value::TYPE_DICTIONARY, result->GetType());
+  base::DictionaryValue* value =
+      static_cast<base::DictionaryValue*>(result.get());
+  int socket_id = -1;
+  EXPECT_TRUE(value->GetInteger("socketId", &socket_id));
+  ASSERT_GT(socket_id, 0);
+}
+
+IN_PROC_BROWSER_TEST_F(SocketApiTest, GetNetworkList) {
+  scoped_refptr<extensions::SocketGetNetworkListFunction> socket_function(
+      new extensions::SocketGetNetworkListFunction());
+  scoped_refptr<Extension> empty_extension = test_util::CreateEmptyExtension();
+
+  socket_function->set_extension(empty_extension.get());
+  socket_function->set_has_callback(true);
+
+  scoped_ptr<base::Value> result(RunFunctionAndReturnSingleResult(
+      socket_function.get(), "[]", browser_context()));
+  ASSERT_EQ(base::Value::TYPE_LIST, result->GetType());

[Yoyo Zhou, 2014/08/11 23:32:57]

Same, but for lists.

[Daniel Nishi, 2014/08/11 23:40:45]

Done.

+
+  // If we're invoking socket tests, all we can confirm is that we have at
+  // least one address, but not what it is.
+  base::ListValue* value = static_cast<base::ListValue*>(result.get());
+  ASSERT_GT(value->GetSize(), 0U);
+}
+
+}  //  namespace extensions