Move more Sockets browser tests into appshell tests.

Move more Sockets browser tests into app_shell_browsertests tests.

BUG=388893
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289018

[Daniel Nishi, 2014-08-11 17:33:21]

PTAL.

[Yoyo Zhou, 2014-08-11 23:32:57]

https://chromiumcodereview.appspot.com/456863003/diff/40001/extensions/browse...
File extensions/browser/api/socket/socket_apitest.cc (right):

https://chromiumcodereview.appspot.com/456863003/diff/40001/extensions/browse...
extensions/browser/api/socket/socket_apitest.cc:31:
static_cast<base::DictionaryValue*>(result.get());
No need to static cast.
DictionaryValue* value = NULL;
ASSERT_TRUE(result->GetAsDictionary(&value));

https://chromiumcodereview.appspot.com/456863003/diff/40001/extensions/browse...
extensions/browser/api/socket/socket_apitest.cc:65:
ASSERT_EQ(base::Value::TYPE_LIST, result->GetType());
Same, but for lists.

[Daniel Nishi, 2014-08-11 23:40:45]

Done for other spots, too.

https://chromiumcodereview.appspot.com/456863003/diff/40001/extensions/browse...
File extensions/browser/api/socket/socket_apitest.cc (right):

https://chromiumcodereview.appspot.com/456863003/diff/40001/extensions/browse...
extensions/browser/api/socket/socket_apitest.cc:31:
static_cast<base::DictionaryValue*>(result.get());
On 2014/08/11 23:32:57, Yoyo Zhou wrote:
> No need to static cast.
> DictionaryValue* value = NULL;
> ASSERT_TRUE(result->GetAsDictionary(&value));

Done.

https://chromiumcodereview.appspot.com/456863003/diff/40001/extensions/browse...
extensions/browser/api/socket/socket_apitest.cc:65:
ASSERT_EQ(base::Value::TYPE_LIST, result->GetType());
On 2014/08/11 23:32:57, Yoyo Zhou wrote:
> Same, but for lists.

Done.

[Yoyo Zhou, 2014-08-11 23:50:06]

LGTM

https://chromiumcodereview.appspot.com/456863003/diff/60001/extensions/browse...
File extensions/browser/api/sockets_udp/sockets_udp_apitest.cc (right):

https://chromiumcodereview.appspot.com/456863003/diff/60001/extensions/browse...
extensions/browser/api/sockets_udp/sockets_udp_apitest.cc:31:
ASSERT_EQ(base::Value::TYPE_DICTIONARY, result->GetType());
nit: don't need this line

[Daniel Nishi, 2014-08-11 23:58:42]

The CQ bit was checked by dhnishi@chromium.org

[commit-bot: I haz the power, 2014-08-12 00:01:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dhnishi@chromium.org/456863003/80001

[commit-bot: I haz the power, 2014-08-12 03:13:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)

[commit-bot: I haz the power, 2014-08-12 05:36:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-12 05:36:07]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)

[Daniel Nishi, 2014-08-12 15:42:01]

The CQ bit was checked by dhnishi@chromium.org

[commit-bot: I haz the power, 2014-08-12 15:49:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dhnishi@chromium.org/456863003/80001

[commit-bot: I haz the power, 2014-08-12 17:54:49]

Change committed as 289018