Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: chrome/browser/extensions/extension_service.h

Issue 456063002: ExtensionUpdater: Abstract ExtensionDownloader creation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments and some cleanup Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 } 42 }
43 43
44 namespace content { 44 namespace content {
45 class DevToolsAgentHost; 45 class DevToolsAgentHost;
46 } 46 }
47 47
48 namespace extensions { 48 namespace extensions {
49 class ComponentLoader; 49 class ComponentLoader;
50 class CrxInstaller; 50 class CrxInstaller;
51 class ExtensionActionStorageManager; 51 class ExtensionActionStorageManager;
52 class ExtensionDownloader;
53 class ExtensionDownloaderDelegate;
52 class ExtensionErrorController; 54 class ExtensionErrorController;
53 class ExtensionRegistry; 55 class ExtensionRegistry;
54 class ExtensionSystem; 56 class ExtensionSystem;
55 class ExtensionUpdater; 57 class ExtensionUpdater;
56 class OneShotEvent; 58 class OneShotEvent;
57 class ExternalInstallManager; 59 class ExternalInstallManager;
58 class SharedModuleService; 60 class SharedModuleService;
59 class UpdateObserver; 61 class UpdateObserver;
60 } // namespace extensions 62 } // namespace extensions
61 63
(...skipping 387 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 451
450 // Set a callback to be called when all external providers are ready and their 452 // Set a callback to be called when all external providers are ready and their
451 // extensions have been installed. 453 // extensions have been installed.
452 void set_external_updates_finished_callback_for_test( 454 void set_external_updates_finished_callback_for_test(
453 const base::Closure& callback) { 455 const base::Closure& callback) {
454 external_updates_finished_callback_ = callback; 456 external_updates_finished_callback_ = callback;
455 } 457 }
456 458
457 459
458 private: 460 private:
461 // Creates an ExtensionDownloader for use by the updater.
462 scoped_ptr<extensions::ExtensionDownloader> CreateExtensionDownloader(
463 extensions::ExtensionDownloaderDelegate* delegate);
464
459 // Reloads the specified extension, sending the onLaunched() event to it if it 465 // Reloads the specified extension, sending the onLaunched() event to it if it
460 // currently has any window showing. |be_noisy| determines whether noisy 466 // currently has any window showing. |be_noisy| determines whether noisy
461 // failures are allowed for unpacked extension installs. 467 // failures are allowed for unpacked extension installs.
462 void ReloadExtensionImpl(const std::string& extension_id, bool be_noisy); 468 void ReloadExtensionImpl(const std::string& extension_id, bool be_noisy);
463 469
464 // content::NotificationObserver implementation: 470 // content::NotificationObserver implementation:
465 virtual void Observe(int type, 471 virtual void Observe(int type,
466 const content::NotificationSource& source, 472 const content::NotificationSource& source,
467 const content::NotificationDetails& details) OVERRIDE; 473 const content::NotificationDetails& details) OVERRIDE;
468 474
(...skipping 251 matching lines...) Expand 10 before | Expand all | Expand 10 after
720 GreylistedExtensionDisabled); 726 GreylistedExtensionDisabled);
721 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest, 727 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
722 GreylistDontEnableManuallyDisabled); 728 GreylistDontEnableManuallyDisabled);
723 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest, 729 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
724 GreylistUnknownDontChange); 730 GreylistUnknownDontChange);
725 731
726 DISALLOW_COPY_AND_ASSIGN(ExtensionService); 732 DISALLOW_COPY_AND_ASSIGN(ExtensionService);
727 }; 733 };
728 734
729 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 735 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/extensions/external_cache.cc ('k') | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698