Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: chrome/browser/ui/webui/history_ui.cc

Issue 454223004: Typecheck JS files for chrome://history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@B_download
Patch Set: fixed issues Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/history_ui.cc
diff --git a/chrome/browser/ui/webui/history_ui.cc b/chrome/browser/ui/webui/history_ui.cc
index c1f0b0a3d1839d48512919134e794a7d529e1068..54fb21a2b3e145892d6dd6c9b088bed94903e5c0 100644
--- a/chrome/browser/ui/webui/history_ui.cc
+++ b/chrome/browser/ui/webui/history_ui.cc
@@ -327,6 +327,10 @@ scoped_ptr<base::DictionaryValue> BrowsingHistoryHandler::HistoryEntry::ToValue(
if (domain.empty())
domain = base::UTF8ToUTF16(url.scheme() + ":");
+ // The items which are to be written into result are also described in
+ // chrome/browser/resources/history/history.js in @typedef for
+ // HistoryEntry. Please update it whenever you add or remove
+ // any keys in result.
result->SetString("domain", domain);
result->SetDouble("time", time.ToJsTime());
@@ -783,6 +787,10 @@ void BrowsingHistoryHandler::QueryComplete(
accept_languages));
}
+ // The items which are to be written into results_info_value_ are also
+ // described in chrome/browser/resources/history/history.js in @typedef for
+ // HistoryQuery. Please update it whenever you add or remove any keys in
+ // results_info_value_.
results_info_value_.SetString("term", search_text);
results_info_value_.SetBoolean("finished", results->reached_beginning());

Powered by Google App Engine
This is Rietveld 408576698