ui/views/window/dialog_delegate_unittest.cc - Issue 454173002: Fixed BubbleBorder sizing problems & added unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/window/dialog_delegate_unittest.cc

Issue 454173002: Fixed BubbleBorder sizing problems & added unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Combined test fixtures and rewrote tests to be more easily maintained. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/window/dialog_delegate_unittest.cc

diff --git a/ui/views/window/dialog_delegate_unittest.cc b/ui/views/window/dialog_delegate_unittest.cc

index b3551043be34cbd7d5048e266b329a513261bb9a..a3a2dc74b50e27adcd67f3db6042040ebb0aea72 100644

--- a/ui/views/window/dialog_delegate_unittest.cc

+++ b/ui/views/window/dialog_delegate_unittest.cc

@@ -189,7 +189,7 @@ TEST_F(DialogTest, HitTest) {

// Ensure that the new style's BubbleFrameView hit-tests as expected.

const NonClientView* view = dialog()->GetWidget()->non_client_view();

BubbleFrameView* frame = static_cast<BubbleFrameView*>(view->frame_view());

- const int border = frame->bubble_border()->GetBorderThickness();

+ const int border = frame->bubble_border()->GetBorderExteriorThickness();

struct {

const int point;

« ui/views/bubble/bubble_border_unittest.cc ('K') | « ui/views/bubble/tray_bubble_view.cc ('k') | no next file » | no next file with comments »