chrome/browser/ui/views/autofill/autofill_dialog_views.cc - Issue 454173002: Fixed BubbleBorder sizing problems & added unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/autofill/autofill_dialog_views.cc

Issue 454173002: Fixed BubbleBorder sizing problems & added unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Combined test fixtures and rewrote tests to be more easily maintained. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/autofill/autofill_dialog_views.cc

diff --git a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc

index d30d6c879c1110189e274b38886be7010b98dc9c..d893e480a309d249d2804275fa1bc9abcb317d61 100644

--- a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc

+++ b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc

@@ -711,7 +711,7 @@ gfx::Rect AutofillDialogViews::OverlayView::ContentBoundsSansBubbleBorder() {

gfx::Rect bounds = GetContentsBounds();

int bubble_width = 5;

if (GetBubbleBorder())

- bubble_width = GetBubbleBorder()->GetBorderThickness();

+ bubble_width = GetBubbleBorder()->GetBorderExteriorThickness();

bounds.Inset(bubble_width, bubble_width, bubble_width, bubble_width);

return bounds;

}

« no previous file with comments | « no previous file | ui/views/bubble/bubble_border.h » ('j') | ui/views/bubble/bubble_border.h » ('J')