Move SocketsTcpApiTest.SocketsTcpCreateGood to app_shell_browsertests.

Move SocketsTcpApiTest.SocketsTcpCreateGood to app_shell_browsertests.

BUG=388893
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288495

[Daniel Nishi, 2014-08-08 00:22:55]

yoz: PTAL.

[Yoyo Zhou, 2014-08-08 01:28:04]

https://codereview.chromium.org/449303002/diff/20001/extensions/browser/api_t...
File extensions/browser/api_test_utils.cc (right):

https://codereview.chromium.org/449303002/diff/20001/extensions/browser/api_t...
extensions/browser/api_test_utils.cc:86: scoped_refptr<Extension>
CreateEmptyExtension() {
I recently found extensions/common/test_util.h. I think this function would be
better placed there. What do you think?

https://codereview.chromium.org/449303002/diff/20001/extensions/browser/api_t...
extensions/browser/api_test_utils.cc:124: base::Value*
RunDelegatelessFunctionAndReturnSingleResult(
I think the default should be with no delegate, since right now we only have
functions that don't need a delegate.

So
RunFunctionAndReturn...
RunFunctionWithDelegateAndReturn...

[Daniel Nishi, 2014-08-08 17:24:08]

https://codereview.chromium.org/449303002/diff/20001/extensions/browser/api_t...
File extensions/browser/api_test_utils.cc (right):

https://codereview.chromium.org/449303002/diff/20001/extensions/browser/api_t...
extensions/browser/api_test_utils.cc:86: scoped_refptr<Extension>
CreateEmptyExtension() {
On 2014/08/08 01:28:04, Yoyo Zhou wrote:
> I recently found extensions/common/test_util.h. I think this function would be
> better placed there. What do you think?

I think it looks better, too.

Done.

https://codereview.chromium.org/449303002/diff/20001/extensions/browser/api_t...
extensions/browser/api_test_utils.cc:124: base::Value*
RunDelegatelessFunctionAndReturnSingleResult(
On 2014/08/08 01:28:04, Yoyo Zhou wrote:
> I think the default should be with no delegate, since right now we only have
> functions that don't need a delegate.
> 
> So
> RunFunctionAndReturn...
> RunFunctionWithDelegateAndReturn...

Done.

[Yoyo Zhou, 2014-08-08 20:12:08]

LGTM

https://chromiumcodereview.appspot.com/449303002/diff/40001/extensions/browse...
File extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc (right):

https://chromiumcodereview.appspot.com/449303002/diff/40001/extensions/browse...
extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc:6: #include
"extensions/browser/api/dns/mock_host_resolver_creator.h"
These don't seem to be used.

https://chromiumcodereview.appspot.com/449303002/diff/40001/extensions/browse...
File extensions/browser/api_test_utils.h (right):

https://chromiumcodereview.appspot.com/449303002/diff/40001/extensions/browse...
extensions/browser/api_test_utils.h:10: #include "base/memory/ref_counted.h"
These new headers don't seem necessary.

https://chromiumcodereview.appspot.com/449303002/diff/40001/extensions/browse...
extensions/browser/api_test_utils.h:48: // RunFunctionAndReturnSingleResult,
except with a NULL implementation of the
This comment needs rewriting.

[Daniel Nishi, 2014-08-08 20:30:26]

https://chromiumcodereview.appspot.com/449303002/diff/40001/extensions/browse...
File extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc (right):

https://chromiumcodereview.appspot.com/449303002/diff/40001/extensions/browse...
extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc:6: #include
"extensions/browser/api/dns/mock_host_resolver_creator.h"
On 2014/08/08 20:12:07, Yoyo Zhou wrote:
> These don't seem to be used.

Done.

https://chromiumcodereview.appspot.com/449303002/diff/40001/extensions/browse...
File extensions/browser/api_test_utils.h (right):

https://chromiumcodereview.appspot.com/449303002/diff/40001/extensions/browse...
extensions/browser/api_test_utils.h:10: #include "base/memory/ref_counted.h"
On 2014/08/08 20:12:07, Yoyo Zhou wrote:
> These new headers don't seem necessary.

Whoops. You are correct.

https://chromiumcodereview.appspot.com/449303002/diff/40001/extensions/browse...
extensions/browser/api_test_utils.h:48: // RunFunctionAndReturnSingleResult,
except with a NULL implementation of the
On 2014/08/08 20:12:07, Yoyo Zhou wrote:
> This comment needs rewriting.

Done.

[Daniel Nishi, 2014-08-08 20:30:29]

The CQ bit was checked by dhnishi@chromium.org

[commit-bot: I haz the power, 2014-08-08 20:33:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dhnishi@chromium.org/449303002/60001

[commit-bot: I haz the power, 2014-08-09 02:53:36]

Change committed as 288495