Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 447033002: [Local NTP] Modify config.js to contain a specifier for NTP design. (Closed)

Created:
6 years, 4 months ago by Mathieu
Modified:
6 years, 4 months ago
Reviewers:
huangs
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Project:
chromium
Visibility:
Public.

Description

[Local NTP] Modify config.js to contain a specifier for ntp design. If MD is enabled, add a value to the config dictionary passed to the page. BUG=400332 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287934

Patch Set 1 #

Patch Set 2 : change of name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/search/local_ntp_source.cc View 1 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
huangs
lgtm
6 years, 4 months ago (2014-08-06 20:49:45 UTC) #1
Mathieu
The CQ bit was checked by mathp@chromium.org
6 years, 4 months ago (2014-08-06 20:50:13 UTC) #2
Mathieu
The CQ bit was unchecked by mathp@chromium.org
6 years, 4 months ago (2014-08-06 20:50:54 UTC) #3
Mathieu
The CQ bit was checked by mathp@chromium.org
6 years, 4 months ago (2014-08-06 20:51:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mathp@chromium.org/447033002/20001
6 years, 4 months ago (2014-08-06 20:52:05 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 02:30:19 UTC) #6
Message was sent while issue was closed.
Change committed as 287934

Powered by Google App Engine
This is Rietveld 408576698