Source/core/inspector/InspectorPageAgent.h - Issue 445023005: DevTools: reduce ResourceAgent dependency on PageAgent.

Unified Diff: Source/core/inspector/InspectorPageAgent.h

Issue 445023005: DevTools: reduce ResourceAgent dependency on PageAgent. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/inspector/InspectorDebuggerAgent.cpp ('K') | « Source/core/inspector/InspectorDebuggerAgent.cpp ('k') | Source/core/inspector/InspectorPageAgent.cpp » ('j') | Source/core/inspector/InspectorResourceAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorPageAgent.h

diff --git a/Source/core/inspector/InspectorPageAgent.h b/Source/core/inspector/InspectorPageAgent.h

index 732b55661673f3c1586b577dcb485f1aa135bec0..c64b0910aeb45e63c2eb38a34c4b54c96622e167 100644

--- a/Source/core/inspector/InspectorPageAgent.h

+++ b/Source/core/inspector/InspectorPageAgent.h

@@ -44,6 +44,7 @@ class Resource;

class DOMWrapperWorld;

class Document;

class DocumentLoader;

+class EditedResourcesContentManager;

class LocalFrame;

class GraphicsContext;

class GraphicsLayer;

@@ -78,7 +79,7 @@ public:

OtherResource

};

- static PassOwnPtrWillBeRawPtr<InspectorPageAgent> create(Page*, InjectedScriptManager*, InspectorClient*, InspectorOverlay*);

+ static PassOwnPtrWillBeRawPtr<InspectorPageAgent> create(Page*, InjectedScriptManager*, EditedResourcesContentManager*, InspectorClient*, InspectorOverlay*);

// Settings overrides.

void setTextAutosizingEnabled(bool);

@@ -165,16 +166,13 @@ public:

void deviceOrPageScaleFactorChanged();

static DocumentLoader* assertDocumentLoader(ErrorString*, LocalFrame*);

InspectorResourceContentLoader* resourceContentLoader() { return m_inspectorResourceContentLoader.get(); }

- void clearEditedResourcesContent();

- void addEditedResourceContent(const String& url, const String& content);

- bool getEditedResourceContent(const String& url, String* content);

virtual void trace(Visitor*) OVERRIDE;

private:

class GetResourceContentLoadListener;

- InspectorPageAgent(Page*, InjectedScriptManager*, InspectorClient*, InspectorOverlay*);

+ InspectorPageAgent(Page*, InjectedScriptManager*, EditedResourcesContentManager*, InspectorClient*, InspectorOverlay*);

bool deviceMetricsChanged(bool enabled, int width, int height, double deviceScaleFactor, bool mobile, bool fitWindow, double scale, double offsetX, double offsetY);

void updateViewMetricsFromState();

void updateViewMetrics(bool enabled, int width, int height, double deviceScaleFactor, bool mobile, bool fitWindow, double scale, double offsetX, double offsetY);

@@ -191,6 +189,7 @@ private:

PassRefPtr<TypeBuilder::Page::FrameResourceTree> buildObjectForFrameTree(LocalFrame*);

RawPtrWillBeMember<Page> m_page;

RawPtrWillBeMember<InjectedScriptManager> m_injectedScriptManager;

+ RawPtrWillBeMember<EditedResourcesContentManager> m_editedResourcesContentManager;

InspectorClient* m_client;

InspectorFrontend::Page* m_frontend;

InspectorOverlay* m_overlay;

@@ -216,7 +215,6 @@ private:

double m_embedderFontScaleFactor;

OwnPtr<InspectorResourceContentLoader> m_inspectorResourceContentLoader;

- HashMap<String, String> m_editedResourceContent;

};