Issue 444013002: [Telemetry] Ensure we close ippet's handle if anything goes wrong.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 444013002: [Telemetry] Ensure we close ippet's handle if anything goes wrong. (Closed)

Created:
6 years, 4 months ago by tonyg

Modified:
6 years, 4 months ago

Reviewers:
dtu

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Telemetry] Ensure we close ippet's handle if anything goes wrong. BUG=400960

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -20 lines)			Patch
	M	tools/telemetry/telemetry/core/platform/power_monitor/ippet_power_monitor.py	View		1 chunk	+22 lines, -20 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dtu

6 years, 4 months ago (2014-08-06 19:04:22 UTC) #2

https://chromiumcodereview.appspot.com/444013002/diff/1/tools/telemetry/telem...
File
tools/telemetry/telemetry/core/platform/power_monitor/ippet_power_monitor.py
(right):

https://chromiumcodereview.appspot.com/444013002/diff/1/tools/telemetry/telem...
tools/telemetry/telemetry/core/platform/power_monitor/ippet_power_monitor.py:143:
self._ippet_handle.Close()
Closing the handle just releases the reference, it doesn't terminate the
process.
if win32process.GetExitCodeProcess(self._ippet_handle) == win32con.STILL_ACTIVE:
  win32process.TerminateProcess(self._ippet_handle)

Expand Messages | Collapse Messages