chrome/browser/resources/help/help_page.js - Issue 443553002: Typecheck chrome://help using CompilerPass.java, everything except dependency to options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/help/help_page.js

Issue 443553002: Typecheck chrome://help using CompilerPass.java, everything except dependency to options (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@true_master

Patch Set: rebase to master, compile everything but dependency to options Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/help/help_page.js

diff --git a/chrome/browser/resources/help/help_page.js b/chrome/browser/resources/help/help_page.js

index 10a1807a93a813abd2386e450a635a8c2ad52c0b..9bbd12838c4c2625e800e1581e8bf42411232b2d 100644

--- a/chrome/browser/resources/help/help_page.js

+++ b/chrome/browser/resources/help/help_page.js

@@ -162,7 +162,7 @@ cr.define('help', function() {

/**

* Assigns |method| to the onclick property of |el| if |el| exists.

* @param {HTMLElement} el The element on which to set the click handler.

- * @param {function} method The click handler.

+ * @param {function()} method The click handler.

Dan Beam 2014/08/13 22:20:07 nit: Function instead

Vitaly Pavlenko 2014/08/14 00:01:02 Done.

* @private

maybeSetOnClick_: function(el, method) {

« no previous file with comments | « chrome/browser/resources/help/channel_change_page.js ('k') | chrome/browser/resources/uber/uber.js » ('j') | ui/webui/resources/js/assert.js » ('J')