chrome/browser/resources/uber/uber_page_manager_observer.js - Issue 443553002: Typecheck chrome://help using CompilerPass.java, everything except dependency to options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/uber/uber_page_manager_observer.js

Issue 443553002: Typecheck chrome://help using CompilerPass.java, everything except dependency to options (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@true_master

Patch Set: fixed one nit Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/uber/uber_page_manager_observer.js

diff --git a/chrome/browser/resources/uber/uber_page_manager_observer.js b/chrome/browser/resources/uber/uber_page_manager_observer.js

index 330fabb30a94303f0706111cca25915c0a57026a..effea4e48b258bae27368116c7d188f4bb9b550a 100644

--- a/chrome/browser/resources/uber/uber_page_manager_observer.js

+++ b/chrome/browser/resources/uber/uber_page_manager_observer.js

@@ -8,7 +8,7 @@ cr.define('uber', function() {

/**

* A PageManager observer that updates the uber page.

* @constructor

- * @implements {PageManager.Observer}

+ * @implements {cr.ui.pageManager.PageManager.Observer}

function PageManagerObserver() {}

@@ -17,7 +17,8 @@ cr.define('uber', function() {

/**

* Informs the uber page when a top-level overlay is opened or closed.

- * @param {Page} page The page that is being shown or was hidden.

+ * @param {cr.ui.pageManager.Page} page The page that is being shown or was

+ * hidden.

* @override

onPageVisibilityChanged: function(page) {

« no previous file with comments | « chrome/browser/resources/help/help_page.js ('k') | chrome/browser/resources/uber/uber_utils.js » ('j') | ui/webui/resources/js/cr/ui/bubble.js » ('J')