ui/android/java/res/layout/dropdown_item.xml - Issue 443193006: Show icons in Android web autofill dropdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/android/java/res/layout/dropdown_item.xml

Issue 443193006: Show icons in Android web autofill dropdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix up build files Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java ('k') | ui/android/java/src/org/chromium/ui/DropdownAdapter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/android/java/res/layout/dropdown_item.xml

diff --git a/ui/android/java/res/layout/dropdown_item.xml b/ui/android/java/res/layout/dropdown_item.xml

index bded0ad992682189db918912a3dfb442a160eaaa..248b4dc69a02c2d51be06818894e15d6eacbb122 100644

--- a/ui/android/java/res/layout/dropdown_item.xml

+++ b/ui/android/java/res/layout/dropdown_item.xml

@@ -6,29 +6,43 @@

-->

<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

- android:id="@+id/dropdown_menu_text"

- android:orientation="vertical"

+ android:orientation="horizontal"

+ android:layout_width="match_parent"

+ android:layout_height="wrap_content"

android:gravity="center_vertical">

- <TextView android:id="@+id/dropdown_label"

- android:layout_width="wrap_content"

+ <LinearLayout

+ android:layout_weight="1"

+ android:layout_width="0dp"

android:layout_height="wrap_content"

- android:layout_marginStart="10dp"

- android:layout_marginEnd="10dp"

- android:ellipsize="end"

- android:singleLine="true"

- android:textAlignment="viewStart"

- android:textSize="18sp"

- android:includeFontPadding="false"/>

- <TextView android:id="@+id/dropdown_sublabel"

+ android:orientation="vertical">

+ <TextView android:id="@+id/dropdown_label"

+ android:layout_width="wrap_content"

+ android:layout_height="wrap_content"

+ android:layout_marginStart="10dp"

+ android:layout_marginEnd="10dp"

+ android:ellipsize="end"

+ android:singleLine="true"

+ android:textAlignment="viewStart"

+ android:textSize="18sp"

+ android:includeFontPadding="false"/>

+ <TextView android:id="@+id/dropdown_sublabel"

+ android:layout_width="wrap_content"

+ android:layout_height="wrap_content"

+ android:layout_marginStart="10dp"

+ android:layout_marginEnd="10dp"

+ android:textSize="14sp"

+ android:textColor="#8b8b8b"

+ android:ellipsize="end"

+ android:singleLine="true"

+ android:textAlignment="viewStart"

+ android:includeFontPadding="false"/>

+ </LinearLayout>

+ <ImageView android:id="@+id/dropdown_icon"

android:layout_width="wrap_content"

android:layout_height="wrap_content"

- android:layout_marginStart="10dp"

- android:layout_marginEnd="10dp"

- android:textSize="14sp"

- android:textColor="#8b8b8b"

- android:ellipsize="end"

- android:singleLine="true"

- android:textAlignment="viewStart"

- android:includeFontPadding="false"/>

+ android:layout_margin="8dp"/>

</LinearLayout>