Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 44223003: DevTools: [CodeMirror] prevent text editor from using incorrect highlighter (Closed)

Created:
7 years, 1 month ago by lushnikov
Modified:
7 years, 1 month ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: [CodeMirror] prevent text editor from using incorrect highlighter In certain cases text editor uses incorrect highlighter when the "Show whitespaces" option is turned on. This is due to the fact that CodeMirror.mimeModes array holds not only strings (as CodeMirroTextEditor assumes), but also objects with a property "name". This patch fixes this glitch. BUG= R=vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/devtools/front_end/CodeMirrorTextEditor.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
lushnikov
PTAL
7 years, 1 month ago (2013-10-25 13:47:22 UTC) #1
vsevik
lgtm
7 years, 1 month ago (2013-10-25 15:25:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/44223003/1
7 years, 1 month ago (2013-10-25 15:25:20 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-25 16:35:25 UTC) #4
Message was sent while issue was closed.
Change committed as 160589

Powered by Google App Engine
This is Rietveld 408576698