Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5083)

Unified Diff: chrome/renderer/resources/extensions/web_view_events.js

Issue 440463002: Fix display:none issue for <webview>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix back the merge change Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/web_view_events.js
diff --git a/chrome/renderer/resources/extensions/web_view_events.js b/chrome/renderer/resources/extensions/web_view_events.js
index 546dff294f74349acfd2f42fe8e593585350976c..c7c40e7af0d044fbc56d9de719ea82d7203b487f 100644
--- a/chrome/renderer/resources/extensions/web_view_events.js
+++ b/chrome/renderer/resources/extensions/web_view_events.js
@@ -20,6 +20,7 @@ var CreateEvent = function(name) {
};
var FrameNameChangedEvent = CreateEvent('webViewInternal.onFrameNameChanged');
+var PluginDestroyedEvent = CreateEvent('webViewInternal.onPluginDestroyed');
var WebRequestMessageEvent = CreateEvent('webViewInternal.onMessage');
// WEB_VIEW_EVENTS is a map of stable <webview> DOM event names to their
@@ -192,6 +193,7 @@ function WebViewEvents(webViewInternal, viewInstanceId) {
// Sets up events.
WebViewEvents.prototype.setup = function() {
this.setupFrameNameChangedEvent();
+ this.setupPluginDestroyedEvent();
this.setupWebRequestEvents();
this.webViewInternal.setupExperimentalContextMenus();
@@ -202,10 +204,15 @@ WebViewEvents.prototype.setup = function() {
};
WebViewEvents.prototype.setupFrameNameChangedEvent = function() {
- var self = this;
FrameNameChangedEvent.addListener(function(e) {
- self.webViewInternal.onFrameNameChanged(e.name);
- }, {instanceId: self.viewInstanceId});
+ this.webViewInternal.onFrameNameChanged(e.name);
+ }.bind(this), {instanceId: this.viewInstanceId});
+};
+
+WebViewEvents.prototype.setupPluginDestroyedEvent = function() {
+ PluginDestroyedEvent.addListener(function(e) {
+ this.webViewInternal.onPluginDestroyed();
+ }.bind(this), {instanceId: this.viewInstanceId});
};
WebViewEvents.prototype.setupWebRequestEvents = function() {

Powered by Google App Engine
This is Rietveld 408576698