Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: chrome/test/data/extensions/platform_apps/web_view/display_none_and_back/main.js

Issue 440463002: Fix display:none issue for <webview>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/platform_apps/web_view/display_none_and_back/main.js
diff --git a/chrome/test/data/extensions/platform_apps/web_view/visibility_changed/main.js b/chrome/test/data/extensions/platform_apps/web_view/display_none_and_back/main.js
similarity index 77%
copy from chrome/test/data/extensions/platform_apps/web_view/visibility_changed/main.js
copy to chrome/test/data/extensions/platform_apps/web_view/display_none_and_back/main.js
index 29591a383de13f22a920b3015e4ce1b605af7505..6a54e0ff509a23fa0d6f369b3fe0ba76c426552d 100644
--- a/chrome/test/data/extensions/platform_apps/web_view/visibility_changed/main.js
+++ b/chrome/test/data/extensions/platform_apps/web_view/display_none_and_back/main.js
@@ -10,6 +10,8 @@ var failTest = function() {
chrome.test.sendMessage('WebViewTest.FAILURE');
};
+var firstTime = true;
+
var startTest = function() {
document.querySelector('#webview-tag-container').innerHTML =
'<webview style="width: 10px; height: 10px; margin: 0; padding: 0;"' +
@@ -17,7 +19,12 @@ var startTest = function() {
var webview = document.querySelector('webview');
var onLoadStop = function(e) {
- chrome.test.sendMessage('WebViewTest.LAUNCHED');
+ if (firstTime) {
+ firstTime = false;
+ chrome.test.sendMessage('WebViewTest.LAUNCHED');
+ } else {
+ chrome.test.sendMessage('WebViewTest.PASSED');
+ }
};
webview.addEventListener('loadstop', onLoadStop);
@@ -30,8 +37,8 @@ window.onAppCommand = function(command) {
case 'hide-guest':
document.querySelector('webview').style.display = 'none';
break;
- case 'hide-embedder':
- document.body.style.display = 'none';
+ case 'show-guest':
+ document.querySelector('webview').style.display = '';
break;
default:
failTest();

Powered by Google App Engine
This is Rietveld 408576698