Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: sdk/lib/isolate/isolate.dart

Issue 43663003: dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/isolate/isolate.dart
diff --git a/sdk/lib/isolate/isolate.dart b/sdk/lib/isolate/isolate.dart
index da5ebe3641dbfaad01b31af94ea9814d622afc34..cf71162d2a088b714365715cbe8111ae48e60e96 100644
--- a/sdk/lib/isolate/isolate.dart
+++ b/sdk/lib/isolate/isolate.dart
@@ -31,7 +31,8 @@ class Isolate {
final SendPort _controlPort;
- Isolate._fromControlPort(this._controlPort);
+ Isolate._fromControlPort(SendPort controlPort)
+ : this._controlPort = controlPort;
Lasse Reichstein Nielsen 2013/10/25 14:28:24 This could be abbreviated again, now that it's not
floitsch 2013/10/25 14:33:14 Not worth a separate CL.
/**
* Creates and spawns an isolate that shares the same code as the current
@@ -98,7 +99,7 @@ abstract class SendPort {
* process). This is currently only supported by the dartvm. For now, the
* dart2js compiler only supports the restricted messages described above.
*
- * The second argument [replyTo] is deprecated.
+ * The second argument [replyTo] is deprecated and its value is ignored.
Lasse Reichstein Nielsen 2013/10/25 14:28:24 How long will it be before we remove this deprecat
floitsch 2013/10/25 14:33:14 Soeren just uploaded a CL. So hopefully Monday. U
*/
void send(var message, [SendPort replyTo]);

Powered by Google App Engine
This is Rietveld 408576698