Linux, Android: fix call to setpriority(2).

base/threading/platform_thread_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/threading/platform_thread.h"
 
 #include <errno.h>
 #include <sys/prctl.h>
 #include <sys/resource.h>
 
@@ skipping 47 matching lines @@
 void PlatformThread::SetThreadPriority(PlatformThreadHandle handle,
                                        ThreadPriority priority) {
   // On Android, we set the Audio priority through JNI as Audio priority
   // will also allow the process to run while it is backgrounded.
   if (priority == kThreadPriority_RealtimeAudio) {
     JNIEnv* env = base::android::AttachCurrentThread();
     Java_ThreadUtils_setThreadPriorityAudio(env, PlatformThread::CurrentId());
     return;
   }
 
-  // setpriority(2) will set a thread's priority if it is passed a tid as
-  // the 'process identifier', not affecting the rest of the threads in the
-  // process. Setting this priority will only succeed if the user has been
-  // granted permission to adjust nice values on the system.
+  // setpriority(2) should change the whole thread group's (i.e. process)
+  // priority. However, on Linux it will only change the current thread. See
+  // the BUGs section in
+  // http://man7.org/linux/man-pages/man2/getpriority.2.html.
   DCHECK_NE(handle.id_, kInvalidThreadId);
   int kNiceSetting = ThreadNiceValue(priority);
-  if (setpriority(PRIO_PROCESS, handle.id_, kNiceSetting))
+  if (setpriority(PRIO_PROCESS, 0, kNiceSetting))

[mdempsky, 2014/08/01 00:05:32]

Can SetThreadPriority() be called by a different thread?  Should there be an
assert to check that handle.id_ == gettid(), or maybe even just use

    handle.id_ == gettid() ? 0 : handle.id_

with a comment that we prefer to use 0 if possible because it allows tighter
sandbox policies?

(Same comment on the _linux.cc file.)

[jln (very slow on Chromium), 2014/08/01 00:39:53]

Ooch. I was a little hasty on this one indeed, thanks.

     LOG(ERROR) << "Failed to set nice value of thread to " << kNiceSetting;
 }
 
 void PlatformThread::SetName(const char* name) {
   ThreadIdNameManager::GetInstance()->SetName(CurrentId(), name);
   tracked_objects::ThreadData::InitializeThreadContext(name);
 
   // Like linux, on android we can get the thread names to show up in the
   // debugger by setting the process name for the LWP.
   // We don't want to do this for the main thread because that would rename
@@ skipping 30 matching lines @@
   // 1Mb is not enough for some tests (see http://crbug.com/263749 for example).
   return 2 * (1 << 20);  // 2Mb
 #endif
 }
 
 bool RegisterThreadUtils(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace base