Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: Source/bindings/dart/DartAsyncLoader.cpp

Issue 428783004: Pass line offsets to Dart_LoadLibrary and Dart_LoadSource. (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/dartium
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/dart/DartAsyncLoader.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/dart/DartAsyncLoader.cpp
diff --git a/Source/bindings/dart/DartAsyncLoader.cpp b/Source/bindings/dart/DartAsyncLoader.cpp
index 1b0af2187d6c8097f78e5b945bc0b3c5ffff308e..7f64cd70e494d83f3edff3407fb280c3c2adae27 100644
--- a/Source/bindings/dart/DartAsyncLoader.cpp
+++ b/Source/bindings/dart/DartAsyncLoader.cpp
@@ -238,10 +238,10 @@ void DartAsyncLoader::findDependences(const String& url, const String& source, i
}
if (m_pendingLibraries.contains(url)) {
- processLibrary(url, source);
+ processLibrary(url, source, lineNumber);
} else {
ASSERT(m_pendingSource.contains(url));
- processSource(url, source);
+ processSource(url, source, lineNumber);
}
}
@@ -257,7 +257,7 @@ void DartAsyncLoader::reportError(const String& error, const String& url)
}
-void DartAsyncLoader::processLibrary(const String& url, const String& source)
+void DartAsyncLoader::processLibrary(const String& url, const String& source, intptr_t lineNumber)
{
ASSERT(m_pendingLibraries.contains(url));
@@ -265,9 +265,9 @@ void DartAsyncLoader::processLibrary(const String& url, const String& source)
if (!m_rootLoaded) {
// A spawned isolate.
m_rootLoaded = true;
- result = Dart_LoadScript(DartUtilities::stringToDartString(url), DartUtilities::convertSourceString(source), 0, 0);
+ result = Dart_LoadScript(DartUtilities::stringToDartString(url), DartUtilities::convertSourceString(source), lineNumber, 0);
} else {
- result = Dart_LoadLibrary(DartUtilities::stringToDartString(url), DartUtilities::convertSourceString(source));
+ result = Dart_LoadLibrary(DartUtilities::stringToDartString(url), DartUtilities::convertSourceString(source), lineNumber, 0);
}
if (Dart_IsError(result))
reportError(result, url);
@@ -275,7 +275,7 @@ void DartAsyncLoader::processLibrary(const String& url, const String& source)
m_pendingLibraries.remove(url);
}
-void DartAsyncLoader::processSource(const String& url, const String& source)
+void DartAsyncLoader::processSource(const String& url, const String& source, intptr_t lineNumber)
{
ASSERT(m_pendingSource.contains(url));
HandleSet* importers = m_pendingSource.take(url);
@@ -284,7 +284,7 @@ void DartAsyncLoader::processSource(const String& url, const String& source)
Dart_Handle library = Dart_HandleFromPersistent(persistent);
Dart_DeletePersistentHandle(persistent);
- Dart_Handle result = Dart_LoadSource(library, DartUtilities::stringToDartString(url), DartUtilities::convertSourceString(source));
+ Dart_Handle result = Dart_LoadSource(library, DartUtilities::stringToDartString(url), DartUtilities::convertSourceString(source), lineNumber, 0);
if (Dart_IsError(result))
reportError(result, url);
}
« no previous file with comments | « Source/bindings/dart/DartAsyncLoader.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698