Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 428783004: Pass line offsets to Dart_LoadLibrary and Dart_LoadSource. (Closed)

Created:
6 years, 4 months ago by rmacnak
Modified:
6 years, 4 months ago
Reviewers:
vsm, hausner, Jacob
CC:
reviews+dom_dartlang.org
Visibility:
Public.

Description

Pass line offsets to Dart_LoadLibrary and Dart_LoadSource. BUG=http://dartbug.com/13460 R=hausner@google.com, jacobr@google.com Committed: https://src.chromium.org/viewvc/blink/branches/dart/dartium?view=rev&revision=179345

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M Source/bindings/dart/DartApplicationLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/dart/DartAsyncLoader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/dart/DartAsyncLoader.cpp View 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmacnak
6 years, 4 months ago (2014-07-31 19:34:10 UTC) #1
hausner
LGTM.
6 years, 4 months ago (2014-07-31 21:16:08 UTC) #2
Jacob
lgtm
6 years, 4 months ago (2014-07-31 21:20:45 UTC) #3
rmacnak
6 years, 4 months ago (2014-07-31 21:24:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r179345 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698