Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: chrome/browser/resources/options/hotword_confirm_dialog.js

Issue 426723004: options: Remove a bunch of useless: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/hotword_confirm_dialog.js
diff --git a/chrome/browser/resources/options/hotword_confirm_dialog.js b/chrome/browser/resources/options/hotword_confirm_dialog.js
index c32b77287edd8947815fa48a424c669b1e82e815..dc5520d07cb21906516d6bd36017e6640dd5ab76 100644
--- a/chrome/browser/resources/options/hotword_confirm_dialog.js
+++ b/chrome/browser/resources/options/hotword_confirm_dialog.js
@@ -31,7 +31,9 @@ cr.define('options', function() {
}
HotwordConfirmDialog.prototype = {
- // Set up the prototype chain
+ // TODO(dbeam): this class should probably derive SettingsDialog again as it
+ // evily duplicates much of ConfirmDialog's functionality, calls methods
+ // on SettingsDialog.prototype, and shadows private method names.
__proto__: ConfirmDialog.prototype,
/**
@@ -61,7 +63,8 @@ cr.define('options', function() {
/**
* Override the initializePage function so that an updated version of
* onPrefChanged_ can be used.
- * @override */
+ * @override
+ */
initializePage: function() {
SettingsDialog.prototype.initializePage.call(this);
« no previous file with comments | « chrome/browser/resources/options/home_page_overlay.js ('k') | chrome/browser/resources/options/import_data_overlay.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698