Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 426723004: options: Remove a bunch of useless: (Closed)

Created:
6 years, 4 months ago by Dan Beam
Modified:
6 years, 4 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, nkostylev+watch_chromium.org, yukishiino+watch_chromium.org, benquan, Ilya Sherman, dyu1, pam+watch_chromium.org, nona+watch_chromium.org, yusukes+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, tfarina, estade+watch_chromium.org, stevenjb+watch_chromium.org, rouslan+autofillwatch_chromium.org, Dane Wallinga
Project:
chromium
Visibility:
Public.

Description

options: Remove a bunch of useless: - doc comments - repetitive default implementations - eventual compile errors and fix a bunch of [new linter] lint errors. TBR=tbreisacher@chromium.org BUG=393873 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286191

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -151 lines) Patch
M chrome/browser/resources/chromeos/bluetooth_options.js View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/browser_options.js View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/fake_bluetooth_overlay_parent.js View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/resources/options/alert_overlay.js View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/autofill_edit_address_overlay.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options/autofill_edit_creditcard_overlay.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options/autofill_options.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options/certificate_backup_overlay.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options/certificate_import_error_overlay.js View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/certificate_manager.js View 10 chunks +13 lines, -14 lines 0 comments Download
M chrome/browser/resources/options/certificate_restore_overlay.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options/chromeos/accounts_options.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options/chromeos/change_picture_options.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options/chromeos/display_options.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options/chromeos/display_overscan.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options/chromeos/internet_detail.js View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/resources/options/chromeos/keyboard_overlay.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options/chromeos/pointer_overlay.js View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/resources/options/chromeos/preferred_networks.js View 4 chunks +5 lines, -13 lines 0 comments Download
M chrome/browser/resources/options/clear_browser_data_overlay.js View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/content_settings.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options/content_settings_exceptions_area.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options/cookies_view.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options/factory_reset_overlay.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options/font_settings.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options/home_page_overlay.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options/hotword_confirm_dialog.js View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/import_data_overlay.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options/language_add_language_overlay.js View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/resources/options/language_dictionary_overlay.js View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/resources/options/language_options.js View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/resources/options/manage_profile_overlay.js View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/managed_user_create_confirm.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options/managed_user_import.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options/managed_user_learn_more.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options/reset_profile_settings_overlay.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options/search_engine_manager.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/search_page.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options/startup_overlay.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/sync_setup_overlay.js View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Beam
6 years, 4 months ago (2014-07-29 03:28:09 UTC) #1
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 4 months ago (2014-07-29 13:24:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/426723004/1
6 years, 4 months ago (2014-07-29 13:25:15 UTC) #3
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 14:10:49 UTC) #4
Message was sent while issue was closed. 
Change committed as 286191

Powered by Google App Engine
This is Rietveld 408576698