third_party/closure_compiler/runner/build_runner_jar.py - Issue 421253006: Add ChromeCodingConvention.java to Closure Compiler to preserve getInstance() type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/closure_compiler/runner/build_runner_jar.py

Issue 421253006: Add ChromeCodingConvention.java to Closure Compiler to preserve getInstance() type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@A_typechecking_about

Patch Set: rebase onto master Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/closure_compiler/compile_modules.py ('k') | third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/closure_compiler/runner/build_runner_jar.py

diff --git a/third_party/closure_compiler/runner/build_runner_jar.py b/third_party/closure_compiler/runner/build_runner_jar.py

index e9f3a254dbac81fa2892981b743dc3a6b7f415ba..fcd2eec19decd9f7811a896346812f18b557ec44 100755

--- a/third_party/closure_compiler/runner/build_runner_jar.py

+++ b/third_party/closure_compiler/runner/build_runner_jar.py

@@ -27,6 +27,7 @@ src_path = rel_to_abs(src_dir)

def run_and_communicate(command, error_template):

+ print >> sys.stderr, command

proc = subprocess.Popen(command, stdout=subprocess.PIPE, shell=True)

proc.communicate()

if proc.returncode: