Add ChromeCodingConvention.java to Closure Compiler to preserve getInstance() type

third_party/closure_compiler/checker.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 import os
 import re
 import subprocess
 import sys
 import tempfile
 
 
 
 class LineNumber(object):
   def __init__(self, file, line_number):
     self.file = file
     self.line_number = int(line_number)
 
 
 class FileCache(object):
   _cache = defaultdict(str)
-    
+
   def _read(self, file):
     file = os.path.abspath(file)
     self._cache[file] = self._cache[file] or open(file, "r").read()
     return self._cache[file]
 
   @staticmethod
   def read(file):
     return FileCache()._read(file)
 
 
@@ skipping 85 matching lines @@
 
     self._debug("Deleting temporary files: " + ", ".join(self._temp_files))
     for f in self._temp_files:
       os.remove(f)
     self._temp_files = []
 
   def _debug(self, msg, error=False):
     if self._verbose:
       print "(INFO) " + msg
 
   def _fatal(self, msg):

[Dan Beam, 2014/07/29 23:49:08]

change to _error, _fatal no longer makes as much sense

[Vitaly Pavlenko, 2014/07/30 00:01:37]

Done.

     print >> sys.stderr, "(FATAL) " + msg

[Dan Beam, 2014/07/29 23:49:08]

(ERROR)

[Vitaly Pavlenko, 2014/07/30 00:01:37]

Done.

     self._clean_up()
-    sys.exit(1)
 
   def _run_command(self, cmd):
     cmd_str = " ".join(cmd)
     self._debug("Running command: " + cmd_str)
 
     devnull = open(os.devnull, "w")
     return subprocess.Popen(
         cmd_str, stdout=devnull, stderr=subprocess.PIPE, shell=True)
 
   def _check_java_path(self):

[Dan Beam, 2014/07/29 23:49:08]

if not self._found_java:
  proc = self._run_command(["which", "java"])
  proc.communicate()
  if proc.returncode == 0:
    self._found_java = True
  else
    self._error("Cannot find java (`which java` => %s)" % proc.returncode)

return self._found_java

[Vitaly Pavlenko, 2014/07/30 00:01:36]

Done.

     if self._found_java:
       return
 
     proc = self._run_command(["which", "java"])
     proc.communicate()
     if proc.returncode == 0:
       self._found_java = True
     else:
       self._fatal("Cannot find java (`which java` => %s)" % proc.returncode)
 
@@ skipping 18 matching lines @@
     errors = filter(None, errors)
     contents = ("\n" + "## ").join("\n\n".join(errors).splitlines())
     return "## " + contents if contents else ""
 
   def _create_temp_file(self, contents):
     with tempfile.NamedTemporaryFile(mode='wt', delete=False) as tmp_file:
       self._temp_files.append(tmp_file.name)
       tmp_file.write(contents)
     return tmp_file.name
 
   def check(self, file, depends=[], externs=[]):

[Dan Beam, 2014/07/29 23:49:08]

if not self._check_java_path():
  return 1, ""

[Vitaly Pavlenko, 2014/07/30 00:01:36]

Done.

     self._debug("FILE: " + file)
 
     if file.endswith("_externs.js"):
       self._debug("Skipping externs: " + file)
       return
 
     self._file_arg = file
 
     tmp_dir = tempfile.gettempdir()
     rel_path = lambda f: os.path.join(os.path.relpath(os.getcwd(), tmp_dir), f)
@@ skipping 14 matching lines @@
     self._debug("Args file: " + args_file)
 
     runner_args = ["--compiler-args-file=" + args_file]
     runner_cmd = self._run_jar(self._runner_jar, args=runner_args)
     (_, stderr) = runner_cmd.communicate()
 
     errors = stderr.strip().split("\n\n")
     self._debug("Summary: " + errors.pop())
 
     output = self._format_errors(map(self._fix_up_error, errors))
+
     if runner_cmd.returncode:
       self._fatal("Error in: " + file + ("\n" + output if output else ""))
     elif output:
       self._debug("Output: " + output)
-   
+
     self._clean_up()
 
-    return runner_cmd.returncode == 0
+    return runner_cmd.returncode == 0, output

[Dan Beam, 2014/07/29 23:49:08]

return runner_cmd.returncode, output

[Vitaly Pavlenko, 2014/07/30 00:01:37]

Done.