Add ChromeCodingConvention.java to Closure Compiler to preserve getInstance() type

third_party/closure_compiler/checker.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 import os
 import re
 import subprocess
 import sys
 import tempfile
 
 
 
 class LineNumber(object):
   def __init__(self, file, line_number):
     self.file = file
     self.line_number = int(line_number)
 
 
 class FileCache(object):
   _cache = defaultdict(str)
-    
+
   def _read(self, file):
     file = os.path.abspath(file)
     self._cache[file] = self._cache[file] or open(file, "r").read()
     return self._cache[file]
 
   @staticmethod
   def read(file):
     return FileCache()._read(file)
 
 
@@ skipping 65 matching lines @@
   _found_java = False
 
   _jar_command = [
     "java",
     "-jar",
     "-Xms1024m",
     "-server",
     "-XX:+TieredCompilation"
   ]
 
-  def __init__(self, verbose=False):
+  def __init__(self, verbose=False, return_output=False):
     current_dir = os.path.join(os.path.dirname(__file__))
     self._compiler_jar = os.path.join(current_dir, "lib", "compiler.jar")
     self._runner_jar = os.path.join(current_dir, "runner", "runner.jar")
     self._temp_files = []
     self._verbose = verbose
+    self._return_output = return_output
 
   def _clean_up(self):
     if not self._temp_files:
       return
 
     self._debug("Deleting temporary files: " + ", ".join(self._temp_files))
     for f in self._temp_files:
       os.remove(f)
     self._temp_files = []
 
@@ skipping 81 matching lines @@
     self._debug("Args file: " + args_file)
 
     runner_args = ["--compiler-args-file=" + args_file]
     runner_cmd = self._run_jar(self._runner_jar, args=runner_args)
     (_, stderr) = runner_cmd.communicate()
 
     errors = stderr.strip().split("\n\n")
     self._debug("Summary: " + errors.pop())
 
     output = self._format_errors(map(self._fix_up_error, errors))
-    if runner_cmd.returncode:
-      self._fatal("Error in: " + file + ("\n" + output if output else ""))
-    elif output:
-      self._debug("Output: " + output)
-   
-    self._clean_up()
+    if self._return_output:
+      self._clean_up()
 
-    return runner_cmd.returncode == 0
+      return output

[Dan Beam, 2014/07/29 19:17:16]

why not just return both the output and returncode as a tuple?

[Vitaly Pavlenko, 2014/07/29 20:26:18]

Done.

+    else:
+      if runner_cmd.returncode:
+        self._fatal("Error in: " + file + ("\n" + output if output else ""))
+      elif output:
+        self._debug("Output: " + output)
+
+      self._clean_up()
+
+      return runner_cmd.returncode == 0