Add ChromeCodingConvention.java to Closure Compiler to preserve getInstance() type

third_party/closure_compiler/coding_conventions_test.py

+#!/usr/bin/env python
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import unittest
+
+from checker import Checker, FileCache
+
+
+class CodingConventionTest(unittest.TestCase):
+  def __init__(self, *args, **kwargs):
+    unittest.TestCase.__init__(self, *args, **kwargs)
+    self.maxDiff = None

[Dan Beam, 2014/07/30 00:13:05]

^ remove this __init__, maxDiff is only used in assertMultiLine() i think

[Vitaly Pavlenko, 2014/07/30 00:21:25]

Done.

+
+  def setUp(self):
+    self._checker = Checker(verbose=False)
+
+  def testGetInstance(self):
+    test_name = "getInstance"

[Dan Beam, 2014/07/30 00:13:05]

just inline "getInstance" instead of making |test_name|

[Vitaly Pavlenko, 2014/07/30 00:21:25]

Done.

+    file_content = """
+var cr = {
+  /** @param {!Function} ctor */
+  addSingletonGetter: function(ctor) {
+    ctor.getInstance = function() {
+      return ctor.instance_ || (ctor.instance_ = new ctor());
+    };
+  }
+};
+
+/** @constructor */
+function Class() {
+  /** @param {number} num */
+  this.needsNumber = function(num) {};
+}
+
+cr.addSingletonGetter(Class);
+Class.getInstance().needsNumber("wrong type");
+"""
+    expected_chunk = "WARNING - actual parameter 1 of Class.needsNumber does not match formal parameter"
+
+    file_path = "/script.js"
+    FileCache._cache[file_path] = file_content
+    _, output = self._checker.check(file_path)
+
+    self.assertTrue(expected_chunk in output,
+        msg="%s\n\nExpected chunk: \n%s\n\nOutput:\n%s\n" % (
+            test_name, expected_chunk, output))
+
+
+if __name__ == "__main__":
+  unittest.main()