Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: Source/core/dom/ExecutionContextClient.h

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/ExecutionContext.cpp ('k') | Source/core/dom/ScriptLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/ExecutionContextClient.h
diff --git a/Source/core/dom/ExecutionContextClient.h b/Source/core/dom/ExecutionContextClient.h
index 2adc833f4be47df9bcd928d72b8d50ff71e0c2d0..32e5579808114c9aedf88470063d422b9c9437d6 100644
--- a/Source/core/dom/ExecutionContextClient.h
+++ b/Source/core/dom/ExecutionContextClient.h
@@ -28,6 +28,7 @@
#define ExecutionContextClient_h
#include "core/frame/ConsoleTypes.h"
+#include "core/inspector/ConsoleMessage.h"
#include "platform/LifecycleNotifier.h"
#include "platform/heap/Handle.h"
#include "platform/weborigin/KURL.h"
@@ -54,7 +55,7 @@ public:
virtual String userAgent(const KURL&) const = 0;
virtual void disableEval(const String& errorMessage) = 0;
virtual SecurityContext& securityContext() = 0;
- virtual void addMessage(MessageSource, MessageLevel, const String& message, const String& sourceURL, unsigned lineNumber, ScriptState*) = 0;
+ virtual void addMessage(PassRefPtr<ConsoleMessage>) = 0;
virtual EventTarget* errorEventTarget() = 0;
virtual void logExceptionToConsole(const String& errorMessage, const String& sourceURL, int lineNumber, int columnNumber, PassRefPtrWillBeRawPtr<ScriptCallStack>) = 0;
virtual double timerAlignmentInterval() const = 0;
@@ -63,8 +64,7 @@ public:
virtual void tasksWereSuspended() { }
virtual void tasksWereResumed() { }
- void addConsoleMessage(MessageSource source, MessageLevel level, const String& message, const String& sourceURL, unsigned lineNumber) { addMessage(source, level, message, sourceURL, lineNumber, 0); }
- void addConsoleMessage(MessageSource source, MessageLevel level, const String& message, ScriptState* state = 0) { addMessage(source, level, message, String(), 0, state); }
+ void addConsoleMessage(PassRefPtr<ConsoleMessage> consoleMessage) { addMessage(consoleMessage); }
protected:
virtual ~ExecutionContextClient() { }
« no previous file with comments | « Source/core/dom/ExecutionContext.cpp ('k') | Source/core/dom/ScriptLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698