Source/core/xml/XMLHttpRequest.cpp - Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/XMLHttpRequest.cpp

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/workers/WorkerReportingProxy.h ('K') | « Source/core/workers/WorkerReportingProxy.h ('k') | Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp » ('j') | Source/web/ServiceWorkerGlobalScopeProxy.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/xml/XMLHttpRequest.cpp

diff --git a/Source/core/xml/XMLHttpRequest.cpp b/Source/core/xml/XMLHttpRequest.cpp

index b3cc69b82597c52b7dde232f35a5fdf020f82482..61ea02233585937c19d4fdab08237def2781c9a0 100644

--- a/Source/core/xml/XMLHttpRequest.cpp

+++ b/Source/core/xml/XMLHttpRequest.cpp

@@ -40,6 +40,7 @@

#include "core/html/DOMFormData.h"

#include "core/html/HTMLDocument.h"

#include "core/html/parser/TextResourceDecoder.h"

+#include "core/inspector/ConsoleMessage.h"

#include "core/inspector/InspectorInstrumentation.h"

#include "core/inspector/InspectorTraceEvents.h"

#include "core/loader/ThreadableLoader.h"

@@ -158,7 +159,7 @@ static void logConsoleError(ExecutionContext* context, const String& message)

return;

// FIXME: It's not good to report the bad usage without indicating what source line it came from.

// We should pass additional parameters so we can tell the console where the mistake occurred.

- context->addConsoleMessage(JSMessageSource, ErrorMessageLevel, message);

+ context->addConsoleMessage(ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, message));

}

PassRefPtrWillBeRawPtr<XMLHttpRequest> XMLHttpRequest::create(ExecutionContext* context, PassRefPtr<SecurityOrigin> securityOrigin)