Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1553)

Unified Diff: Source/core/rendering/shapes/ShapeOutsideInfo.cpp

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/shapes/ShapeOutsideInfo.cpp
diff --git a/Source/core/rendering/shapes/ShapeOutsideInfo.cpp b/Source/core/rendering/shapes/ShapeOutsideInfo.cpp
index 603f6d432d2007cb3b5752796c29fa8f89a2ea16..b0370c8b4c9807ea1a26220d77f31d7d9391dff0 100644
--- a/Source/core/rendering/shapes/ShapeOutsideInfo.cpp
+++ b/Source/core/rendering/shapes/ShapeOutsideInfo.cpp
@@ -30,6 +30,7 @@
#include "config.h"
#include "core/rendering/shapes/ShapeOutsideInfo.h"
+#include "core/inspector/ConsoleMessage.h"
#include "core/rendering/FloatingObjects.h"
#include "core/rendering/RenderBlockFlow.h"
#include "core/rendering/RenderBox.h"
@@ -93,7 +94,7 @@ static bool checkShapeImageOrigin(Document& document, const StyleImage& styleIma
const KURL& url = imageResource.url();
String urlString = url.isNull() ? "''" : url.elidedString();
- document.addConsoleMessage(SecurityMessageSource, ErrorMessageLevel, "Unsafe attempt to load URL " + urlString + ".");
+ document.addConsoleMessage(ConsoleMessage::create(SecurityMessageSource, ErrorMessageLevel, "Unsafe attempt to load URL " + urlString + "."));
return false;
}
@@ -126,7 +127,7 @@ PassOwnPtr<Shape> ShapeOutsideInfo::createShapeForImage(StyleImage* styleImage,
: LayoutRect(LayoutPoint(), imageSize);
if (!isValidRasterShapeRect(marginRect) || !isValidRasterShapeRect(imageRect)) {
- m_renderer.document().addConsoleMessage(RenderingMessageSource, ErrorMessageLevel, "The shape-outside image is too large.");
+ m_renderer.document().addConsoleMessage(ConsoleMessage::create(RenderingMessageSource, ErrorMessageLevel, "The shape-outside image is too large."));
return Shape::createEmptyRasterShape(writingMode, margin);
}

Powered by Google App Engine
This is Rietveld 408576698