Source/core/page/DOMSelection.cpp - Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/DOMSelection.cpp

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/DOMSelection.cpp

diff --git a/Source/core/page/DOMSelection.cpp b/Source/core/page/DOMSelection.cpp

index 1f042da605830ce0cbbf972fcfa962b2717481f3..49ead12e1e8b65336ce055467f6fc1de56a7d4ce 100644

--- a/Source/core/page/DOMSelection.cpp

+++ b/Source/core/page/DOMSelection.cpp

@@ -43,6 +43,7 @@

#include "core/editing/TextIterator.h"

#include "core/editing/htmlediting.h"

#include "core/frame/LocalFrame.h"

+#include "core/inspector/ConsoleMessage.h"

#include "wtf/text/WTFString.h"

namespace blink {

@@ -562,7 +563,7 @@ bool DOMSelection::isValidForPosition(Node* node) const

void DOMSelection::addConsoleError(const String& message)

{

if (m_treeScope)

- m_treeScope->document().addConsoleMessage(JSMessageSource, ErrorMessageLevel, message);

+ m_treeScope->document().addConsoleMessage(ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, message));

}

} // namespace blink

« Source/core/frame/csp/CSPDirectiveList.cpp ('K') | « Source/core/page/CreateWindow.cpp ('k') | Source/core/page/EventSource.cpp » ('j') | Source/core/workers/WorkerGlobalScope.cpp » ('J')