Source/core/html/parser/XSSAuditor.cpp - Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/parser/XSSAuditor.cpp

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/frame/csp/CSPDirectiveList.cpp ('K') | « Source/core/html/canvas/WebGLRenderingContextBase.cpp ('k') | Source/core/html/parser/XSSAuditorDelegate.cpp » ('j') | Source/core/workers/WorkerGlobalScope.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/parser/XSSAuditor.cpp

diff --git a/Source/core/html/parser/XSSAuditor.cpp b/Source/core/html/parser/XSSAuditor.cpp

index 70aefd311a6e7973c5f8201f025bb5aa9655ba00..f42c05a9b72e1e6920d8497a4c4d7c38d1aa3dd1 100644

--- a/Source/core/html/parser/XSSAuditor.cpp

+++ b/Source/core/html/parser/XSSAuditor.cpp

@@ -32,14 +32,15 @@

#include "core/XLinkNames.h"

#include "core/dom/Document.h"

#include "core/frame/LocalFrame.h"

+#include "core/frame/Settings.h"

#include "core/frame/csp/ContentSecurityPolicy.h"

#include "core/html/HTMLParamElement.h"

#include "core/html/parser/HTMLDocumentParser.h"

#include "core/html/parser/HTMLParserIdioms.h"

#include "core/html/parser/TextResourceDecoder.h"

#include "core/html/parser/XSSAuditorDelegate.h"

+#include "core/inspector/ConsoleMessage.h"

#include "core/loader/DocumentLoader.h"

-#include "core/frame/Settings.h"

#include "platform/JSONValues.h"

#include "platform/network/FormData.h"

#include "platform/text/DecodeEscapeSequences.h"

@@ -345,7 +346,7 @@ void XSSAuditor::init(Document* document, XSSAuditorDelegate* auditorDelegate)

}

if (xssProtectionHeader == ReflectedXSSInvalid)

- document->addConsoleMessage(SecurityMessageSource, ErrorMessageLevel, "Error parsing header X-XSS-Protection: " + headerValue + ": " + errorDetails + " at character position " + String::format("%u", errorPosition) + ". The default protections will be applied.");

+ document->addConsoleMessage(ConsoleMessage::create(SecurityMessageSource, ErrorMessageLevel, "Error parsing header X-XSS-Protection: " + headerValue + ": " + errorDetails + " at character position " + String::format("%u", errorPosition) + ". The default protections will be applied."));

ReflectedXSSDisposition cspHeader = document->contentSecurityPolicy()->reflectedXSSDisposition();

m_didSendValidCSPHeader = cspHeader != ReflectedXSSUnset && cspHeader != ReflectedXSSInvalid;