Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: Source/core/dom/Document.h

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Document.h
diff --git a/Source/core/dom/Document.h b/Source/core/dom/Document.h
index a68d8782bbfe06f0d422d6835e929267e1d24ffb..034503b2dadc14aa64ac7b024489df7296626b08 100644
--- a/Source/core/dom/Document.h
+++ b/Source/core/dom/Document.h
@@ -46,6 +46,7 @@
#include "core/dom/ViewportDescription.h"
#include "core/dom/custom/CustomElement.h"
#include "core/html/CollectionType.h"
+#include "core/inspector/ConsoleMessage.h"
#include "core/page/FocusType.h"
#include "core/page/PageVisibilityState.h"
#include "platform/Length.h"
@@ -1014,7 +1015,7 @@ public:
void didAssociateFormControl(Element*);
- void addConsoleMessageWithRequestIdentifier(MessageSource, MessageLevel, const String& message, unsigned long requestIdentifier);
+ virtual void addMessage(PassRefPtr<ConsoleMessage>) OVERRIDE FINAL;
virtual LocalDOMWindow* executingWindow() OVERRIDE FINAL;
LocalFrame* executingFrame();
@@ -1117,8 +1118,6 @@ private:
virtual KURL virtualCompleteURL(const String&) const OVERRIDE FINAL; // Same as completeURL() for the same reason as above.
virtual void reportBlockedScriptExecutionToInspector(const String& directiveText) OVERRIDE FINAL;
- virtual void addMessage(MessageSource, MessageLevel, const String& message, const String& sourceURL, unsigned lineNumber, ScriptState*) OVERRIDE FINAL;
- void internalAddMessage(MessageSource, MessageLevel, const String& message, const String& sourceURL, unsigned lineNumber, PassRefPtrWillBeRawPtr<ScriptCallStack>, ScriptState*);
virtual double timerAlignmentInterval() const OVERRIDE FINAL;

Powered by Google App Engine
This is Rietveld 408576698