Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: Source/core/page/DOMSelection.cpp

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/page/CreateWindow.cpp ('k') | Source/core/page/EventSource.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2009 Apple Inc. All rights reserved.
3 * Copyright (C) 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 25 matching lines...) Expand all
36 #include "bindings/core/v8/ExceptionStatePlaceholder.h" 36 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
37 #include "core/dom/Document.h" 37 #include "core/dom/Document.h"
38 #include "core/dom/ExceptionCode.h" 38 #include "core/dom/ExceptionCode.h"
39 #include "core/dom/Node.h" 39 #include "core/dom/Node.h"
40 #include "core/dom/Range.h" 40 #include "core/dom/Range.h"
41 #include "core/dom/TreeScope.h" 41 #include "core/dom/TreeScope.h"
42 #include "core/editing/FrameSelection.h" 42 #include "core/editing/FrameSelection.h"
43 #include "core/editing/TextIterator.h" 43 #include "core/editing/TextIterator.h"
44 #include "core/editing/htmlediting.h" 44 #include "core/editing/htmlediting.h"
45 #include "core/frame/LocalFrame.h" 45 #include "core/frame/LocalFrame.h"
46 #include "core/inspector/ConsoleMessage.h"
46 #include "wtf/text/WTFString.h" 47 #include "wtf/text/WTFString.h"
47 48
48 namespace blink { 49 namespace blink {
49 50
50 static Node* selectionShadowAncestor(LocalFrame* frame) 51 static Node* selectionShadowAncestor(LocalFrame* frame)
51 { 52 {
52 Node* node = frame->selection().selection().base().anchorNode(); 53 Node* node = frame->selection().selection().base().anchorNode();
53 if (!node) 54 if (!node)
54 return 0; 55 return 0;
55 56
(...skipping 499 matching lines...) Expand 10 before | Expand all | Expand 10 after
555 { 556 {
556 ASSERT(m_frame); 557 ASSERT(m_frame);
557 if (!node) 558 if (!node)
558 return true; 559 return true;
559 return node->document() == m_frame->document(); 560 return node->document() == m_frame->document();
560 } 561 }
561 562
562 void DOMSelection::addConsoleError(const String& message) 563 void DOMSelection::addConsoleError(const String& message)
563 { 564 {
564 if (m_treeScope) 565 if (m_treeScope)
565 m_treeScope->document().addConsoleMessage(JSMessageSource, ErrorMessageL evel, message); 566 m_treeScope->document().addConsoleMessage(ConsoleMessage::create(JSMessa geSource, ErrorMessageLevel, message));
566 } 567 }
567 568
568 } // namespace blink 569 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/page/CreateWindow.cpp ('k') | Source/core/page/EventSource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698