chrome/browser/extensions/extension_context_menu_model.h - Issue 419023002: Move ShowPopup logic from BrowserActionsContainer to BrowserActionView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_context_menu_model.h

Issue 419023002: Move ShowPopup logic from BrowserActionsContainer to BrowserActionView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_context_menu_model.h

diff --git a/chrome/browser/extensions/extension_context_menu_model.h b/chrome/browser/extensions/extension_context_menu_model.h

index 4685b6c9f42def7fe89997d542f87f85b64a12f7..a07d9d534fac896f25eae444bf455c9276b2a9b1 100644

--- a/chrome/browser/extensions/extension_context_menu_model.h

+++ b/chrome/browser/extensions/extension_context_menu_model.h

@@ -40,7 +40,8 @@ class ExtensionContextMenuModel

public:

// Called when the user selects the menu item which requests that the

// popup be shown and inspected.

- virtual void InspectPopup(ExtensionAction* action) = 0;

+ // The delegate should know which popup to display.

+ virtual void InspectPopup() = 0;

protected:

virtual ~PopupDelegate() {}

« no previous file with comments | « no previous file | chrome/browser/extensions/extension_context_menu_model.cc » ('j') | no next file with comments »