Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: extensions/shell/browser/dns_apitest.cc

Issue 413353003: Move the app_shell_browsertests DNS apitest to chrome/browser/api/dns. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: todo Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/shell/app_shell.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/shell/browser/dns_apitest.cc
diff --git a/extensions/shell/browser/dns_apitest.cc b/extensions/shell/browser/dns_apitest.cc
deleted file mode 100644
index fa2ec2fa7858ce598b1d7a3aca0cca7a4f03f6b0..0000000000000000000000000000000000000000
--- a/extensions/shell/browser/dns_apitest.cc
+++ /dev/null
@@ -1,128 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "base/macros.h"
-#include "base/memory/ref_counted.h"
-#include "base/memory/scoped_ptr.h"
-#include "base/values.h"
-#include "extensions/browser/api/dns/dns_api.h"
-#include "extensions/browser/api/dns/host_resolver_wrapper.h"
-#include "extensions/browser/api/dns/mock_host_resolver_creator.h"
-#include "extensions/browser/api_test_utils.h"
-#include "extensions/browser/extension_function_dispatcher.h"
-#include "extensions/common/extension.h"
-#include "extensions/common/extension_builder.h"
-#include "extensions/shell/test/shell_test.h"
-#include "net/base/net_errors.h"
-
-using extensions::api_test_utils::RunFunctionAndReturnSingleResult;
-
-namespace extensions {
-
-namespace {
-
-class TestFunctionDispatcherDelegate
- : public ExtensionFunctionDispatcher::Delegate {
- public:
- TestFunctionDispatcherDelegate() {}
- virtual ~TestFunctionDispatcherDelegate() {}
-
- // NULL implementation.
- private:
- DISALLOW_COPY_AND_ASSIGN(TestFunctionDispatcherDelegate);
-};
-
-} // namespace
-
-class DnsApiTest : public AppShellTest {
- public:
- DnsApiTest() : resolver_creator_(new MockHostResolverCreator()) {}
-
- private:
- virtual void SetUpOnMainThread() OVERRIDE {
- AppShellTest::SetUpOnMainThread();
- HostResolverWrapper::GetInstance()->SetHostResolverForTesting(
- resolver_creator_->CreateMockHostResolver());
- }
-
- virtual void TearDownOnMainThread() OVERRIDE {
- HostResolverWrapper::GetInstance()->SetHostResolverForTesting(NULL);
- resolver_creator_->DeleteMockHostResolver();
- AppShellTest::TearDownOnMainThread();
- }
-
- // The MockHostResolver asserts that it's used on the same thread on which
- // it's created, which is actually a stronger rule than its real counterpart.
- // But that's fine; it's good practice.
- scoped_refptr<MockHostResolverCreator> resolver_creator_;
-};
-
-IN_PROC_BROWSER_TEST_F(DnsApiTest, DnsResolveIPLiteral) {
- scoped_refptr<DnsResolveFunction> resolve_function(new DnsResolveFunction());
- scoped_refptr<Extension> empty_extension(
- ExtensionBuilder()
- .SetManifest(
- DictionaryBuilder().Set("name", "Test").Set("version", "1.0"))
- .Build());
-
- resolve_function->set_extension(empty_extension.get());
- resolve_function->set_has_callback(true);
-
- TestFunctionDispatcherDelegate delegate;
- scoped_ptr<ExtensionFunctionDispatcher> dispatcher(
- new ExtensionFunctionDispatcher(browser_context(), &delegate));
-
- scoped_ptr<base::Value> result(
- RunFunctionAndReturnSingleResult(resolve_function.get(),
- "[\"127.0.0.1\"]",
- browser_context(),
- dispatcher.Pass()));
- base::DictionaryValue* dict = NULL;
- ASSERT_TRUE(result->GetAsDictionary(&dict));
-
- int result_code = 0;
- EXPECT_TRUE(dict->GetInteger("resultCode", &result_code));
- EXPECT_EQ(net::OK, result_code);
-
- std::string address;
- EXPECT_TRUE(dict->GetString("address", &address));
- EXPECT_EQ("127.0.0.1", address);
-}
-
-IN_PROC_BROWSER_TEST_F(DnsApiTest, DnsResolveHostname) {
- scoped_refptr<DnsResolveFunction> resolve_function(new DnsResolveFunction());
- scoped_refptr<Extension> empty_extension(
- ExtensionBuilder()
- .SetManifest(
- DictionaryBuilder().Set("name", "Test").Set("version", "1.0"))
- .Build());
-
- resolve_function->set_extension(empty_extension.get());
- resolve_function->set_has_callback(true);
-
- TestFunctionDispatcherDelegate delegate;
- scoped_ptr<ExtensionFunctionDispatcher> dispatcher(
- new ExtensionFunctionDispatcher(browser_context(), &delegate));
-
- std::string function_arguments("[\"");
- function_arguments += MockHostResolverCreator::kHostname;
- function_arguments += "\"]";
- scoped_ptr<base::Value> result(
- RunFunctionAndReturnSingleResult(resolve_function.get(),
- function_arguments,
- browser_context(),
- dispatcher.Pass()));
- base::DictionaryValue* dict = NULL;
- ASSERT_TRUE(result->GetAsDictionary(&dict));
-
- int result_code = 0;
- EXPECT_TRUE(dict->GetInteger("resultCode", &result_code));
- EXPECT_EQ(net::OK, result_code);
-
- std::string address;
- EXPECT_TRUE(dict->GetString("address", &address));
- EXPECT_EQ(MockHostResolverCreator::kAddress, address);
-}
-
-} // namespace extensions
« no previous file with comments | « extensions/shell/app_shell.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698