Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: extensions/shell/app_shell.gyp

Issue 413353003: Move the app_shell_browsertests DNS apitest to chrome/browser/api/dns. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/dns/dns_apitest.cc ('k') | extensions/shell/browser/dns_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/shell/app_shell.gyp
diff --git a/extensions/shell/app_shell.gyp b/extensions/shell/app_shell.gyp
index d95b38557369273e574130e385057e1948762e6b..bde6995fc9d744ca4d459713170fe9b4020264c5 100644
--- a/extensions/shell/app_shell.gyp
+++ b/extensions/shell/app_shell.gyp
@@ -210,7 +210,9 @@
],
'sources': [
# TODO(yoz): Refactor once we have a second test target.
- 'browser/dns_apitest.cc',
+ # TODO(yoz): Something is off here; should this .gyp file be
+ # in the parent directory?
James Cook 2014/07/25 02:52:35 nit: Maybe don't indent this line? It looks funny.
Yoyo Zhou 2014/07/25 02:57:01 I agree. app_shell_browsertests made more sense wh
James Cook 2014/07/25 15:44:22 Not sure. What does content do?
Yoyo Zhou 2014/07/25 20:43:38 content_shell -> content_shell_lib content_browser
+ '../browser/api/dns/dns_apitest.cc',
'browser/shell_browsertest.cc',
'test/shell_test.h',
'test/shell_test.cc',
« no previous file with comments | « extensions/browser/api/dns/dns_apitest.cc ('k') | extensions/shell/browser/dns_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698