Move the app_shell_browsertests DNS apitest to chrome/browser/api/dns.

extensions/shell/app_shell.gyp

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
   },
   'targets': [
     {
@@ skipping 192 matching lines @@
         '<(DEPTH)/content/content_shell_and_tests.gyp:content_browser_test_support',
         '<(DEPTH)/content/content_shell_and_tests.gyp:test_support_content',
         '<(DEPTH)/extensions/extensions.gyp:extensions_test_support',
         '<(DEPTH)/testing/gtest.gyp:gtest',
       ],
       'defines': [
         'HAS_OUT_OF_PROC_TEST_RUNNER',
       ],
       'sources': [
         # TODO(yoz): Refactor once we have a second test target.
-        'browser/dns_apitest.cc',
+        # TODO(yoz): Something is off here; should this .gyp file be
+        #     in the parent directory?

[James Cook, 2014/07/25 02:52:35]

nit: Maybe don't indent this line? It looks funny.

Not for this CL: I think this is a sign that these should be
"extensions_browsertests" and live in the parent directory. Maybe. How does
src/content handle the distinction between content_shell and
content_browsertests?

[Yoyo Zhou, 2014/07/25 02:57:01]

I agree. app_shell_browsertests made more sense when this was a test for testing
app_shell. Now that app_shell is under the dominion of extensions, and tests are
running with ExtensionsShell, it's more sensible to not have app_shell in the
name. What to call app_shell_lib, though?

[James Cook, 2014/07/25 15:44:22]

Not sure. What does content do?

[Yoyo Zhou, 2014/07/25 20:43:38]

content_shell -> content_shell_lib
content_browsertests -> content_shell_lib

"extensions_shell_lib" is a possibility. Strange because there isn't an
extensions shell. "app_shell_lib" is not too bad if we leave it alone though.

+        '../browser/api/dns/dns_apitest.cc',
         'browser/shell_browsertest.cc',
         'test/shell_test.h',
         'test/shell_test.cc',
         'test/shell_test_launcher_delegate.cc',
         'test/shell_test_launcher_delegate.h',
         'test/shell_tests_main.cc',
       ],
     },
   ],  # targets
 }