Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 413353003: Move the app_shell_browsertests DNS apitest to chrome/browser/api/dns. (Closed)

Created:
6 years, 5 months ago by Yoyo Zhou
Modified:
6 years, 4 months ago
Reviewers:
James Cook
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move the app_shell_browsertests DNS apitest to chrome/browser/api/dns. BUG=388893 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285775

Patch Set 1 #

Total comments: 4

Patch Set 2 : todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -128 lines) Patch
A + extensions/browser/api/dns/dns_apitest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M extensions/shell/app_shell.gyp View 1 1 chunk +3 lines, -1 line 0 comments Download
D extensions/shell/browser/dns_apitest.cc View 1 chunk +0 lines, -128 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Yoyo Zhou
6 years, 5 months ago (2014-07-25 00:29:59 UTC) #1
James Cook
LGTM https://chromiumcodereview.appspot.com/413353003/diff/1/extensions/shell/app_shell.gyp File extensions/shell/app_shell.gyp (right): https://chromiumcodereview.appspot.com/413353003/diff/1/extensions/shell/app_shell.gyp#newcode214 extensions/shell/app_shell.gyp:214: # in the parent directory? nit: Maybe don't ...
6 years, 5 months ago (2014-07-25 02:52:35 UTC) #2
Yoyo Zhou
https://chromiumcodereview.appspot.com/413353003/diff/1/extensions/shell/app_shell.gyp File extensions/shell/app_shell.gyp (right): https://chromiumcodereview.appspot.com/413353003/diff/1/extensions/shell/app_shell.gyp#newcode214 extensions/shell/app_shell.gyp:214: # in the parent directory? On 2014/07/25 02:52:35, James ...
6 years, 5 months ago (2014-07-25 02:57:01 UTC) #3
James Cook
https://chromiumcodereview.appspot.com/413353003/diff/1/extensions/shell/app_shell.gyp File extensions/shell/app_shell.gyp (right): https://chromiumcodereview.appspot.com/413353003/diff/1/extensions/shell/app_shell.gyp#newcode214 extensions/shell/app_shell.gyp:214: # in the parent directory? On 2014/07/25 02:57:01, Yoyo ...
6 years, 4 months ago (2014-07-25 15:44:22 UTC) #4
Yoyo Zhou
fixed the TODO. https://chromiumcodereview.appspot.com/413353003/diff/1/extensions/shell/app_shell.gyp File extensions/shell/app_shell.gyp (right): https://chromiumcodereview.appspot.com/413353003/diff/1/extensions/shell/app_shell.gyp#newcode214 extensions/shell/app_shell.gyp:214: # in the parent directory? On ...
6 years, 4 months ago (2014-07-25 20:43:38 UTC) #5
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 4 months ago (2014-07-25 20:43:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/413353003/20001
6 years, 4 months ago (2014-07-25 20:45:16 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-26 18:03:28 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-07-26 18:26:30 UTC) #9
Message was sent while issue was closed.
Change committed as 285775

Powered by Google App Engine
This is Rietveld 408576698