DevTools: Support Blackbox/Disabled options in framework blackboxing UI dialog.

Source/devtools/front_end/settings/SettingsScreen.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 677 matching lines @@
  * @extends {WebInspector.Object}
  * @param {!Array.<{id: string, placeholder: (string|undefined), options: (!Array.<string>|undefined)}>} columns
  * @param {function(!Element, {id: string, placeholder: (string|undefined), options: (!Array.<string>|undefined)}, ?string)} itemRenderer
  */
 WebInspector.SettingsList = function(columns, itemRenderer)
 {
     this.element = document.createElementWithClass("div", "settings-list");
     this.element.tabIndex = -1;
     this._itemRenderer = itemRenderer;
     /** @type {!Object.<?string, !Element>} */
-    this._listItems = {};
+    this._listItems = { __proto__: null };

[vsevik, 2014/07/28 08:27:57]

StringMap?

[aandrey, 2014/07/28 12:42:38]

StringMap doesn't accept null as a key.
Also itemID can not be "__proto__" here, so it's safe to use an object.

     /** @type {!Array.<?string>} */
     this._ids = [];
     this._columns = columns;
 }
 
 WebInspector.SettingsList.Events = {
     Selected:  "Selected",
     Removed:  "Removed",
     DoubleClicked:  "DoubleClicked",
 }
@@ skipping 47 matching lines @@
         }
 
         return listItem;
     },
 
     /**
      * @param {?string} id
      */
     removeItem: function(id)
     {
-        this._listItems[id].remove();
+        if (this._listItems[id])
+            this._listItems[id].remove();
         delete this._listItems[id];
         this._ids.remove(id);
         if (id === this._selectedId) {
             delete this._selectedId;
             if (this._ids.length)
                 this.selectItem(this._ids[0]);
         }
     },
 
     /**
@@ skipping 111 matching lines @@
      * @return {!Element}
      */
     addItem: function(itemId, beforeId)
     {
         var listItem = WebInspector.SettingsList.prototype.addItem.call(this, itemId, beforeId);
         listItem.classList.add("editable");
         return listItem;
     },
 
     /**
+     * @param {?string} itemId
+     */
+    refreshItem: function(itemId)
+    {
+        if (!itemId)
+            return;
+        var listItem = this._listItems[itemId];
+        if (!listItem)
+            return;
+        for (var i = 0; i < this._columns.length; ++i) {
+            var column = this._columns[i];
+            var columnId = column.id;
+
+            var value = this._valuesProvider(itemId, columnId);
+            var textElement = this._textElements[itemId][columnId];
+            textElement.textContent = value;
+            textElement.title = value;
+
+            var editElement = this._editInputElements[itemId][columnId];
+            this._setEditElementValue(editElement, value || "");
+        }
+    },
+
+    /**
      * @param {!Element} columnElement
      * @param {{id: string, placeholder: (string|undefined), options: (!Array.<string>|undefined)}} column
      * @param {?string} itemId
      */
     _renderColumn: function(columnElement, column, itemId)
     {
         var columnId = column.id;
         if (itemId === null) {
             this._createEditElement(columnElement, column, itemId);
             return;
@@ skipping 205 matching lines @@
             var columnId = columns[i];
             var editElement = this._addInputElements[columnId];
             this._setEditElementValue(editElement, "");
         }
     },
 
     __proto__: WebInspector.SettingsList.prototype
 }
 
 WebInspector._settingsController = new WebInspector.SettingsController();