DevTools: Support Blackbox/Disabled options in framework blackboxing UI dialog.

Source/devtools/front_end/common/Settings.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 192 matching lines @@
  * @constructor
  * @extends {WebInspector.Setting}
  * @param {string} name
  * @param {string} defaultValue
  * @param {!WebInspector.Object} eventSupport
  * @param {?Storage} storage
  * @param {string=} regexFlags
  */
 WebInspector.RegExpSetting = function(name, defaultValue, eventSupport, storage, regexFlags)
 {
-    WebInspector.Setting.call(this, name, [defaultValue], eventSupport, storage);
+    WebInspector.Setting.call(this, name, defaultValue ? [{ pattern: defaultValue }] : [], eventSupport, storage);
     this._regexFlags = regexFlags;
 }
 
 WebInspector.RegExpSetting.prototype = {
     /**
      * @override
      * @return {string}
      */
     get: function()
     {
-        return this.getAsArray().join("|");
+        var result = [];
+        var items = this.getAsArray();
+        for (var i = 0; i < items.length; ++i) {
+            var item = items[i];
+            if (item.pattern && !item.disabled)
+                result.push(item.pattern);
+        }
+        return result.join("|");
     },
 
     /**
-     * @return {!Array.<string>}
+     * @return {!Array.<{pattern: string, disabled: (boolean|undefined)}>}
      */
     getAsArray: function()
     {
         var value = WebInspector.Setting.prototype.get.call(this);
-        if (typeof value === "string") // Backward compatibility.
+        // Backward compatibility #1.

[vsevik, 2014/07/28 08:27:57]

Can we use WebInspector.VersionController to avoid this?

[aandrey, 2014/07/28 12:42:38]

Done.

+        if (typeof value === "string")
             value = [value];
-        value.remove("");
-        return value;
+        // Backward compatibility #2.
+        var result = [];
+        for (var i = 0; i < value.length; ++i) {
+            if (typeof value[i] === "string")
+                value[i] = { pattern: value[i] };
+            if (value[i].pattern)
+                result.push(value[i]);
+        }
+        return result;
     },
 
     /**
      * @override
      * @param {string} value
      */
     set: function(value)
     {
-        this.setAsArray([value]);
+        this.setAsArray([{ pattern: value }]);
     },
 
     /**
-     * @param {!Array.<string>} value
+     * @param {!Array.<{pattern: string, disabled: (boolean|undefined)}>} value
      */
     setAsArray: function(value)
     {
         delete this._regex;
-        value.remove("");
-        WebInspector.Setting.prototype.set.call(this, value);
+        var result = [];
+        for (var i = 0; i < value.length; ++i) {
+            if (value[i].pattern)
+                result.push(value[i]);
+        }
+        WebInspector.Setting.prototype.set.call(this, result);
     },
 
     /**
      * @return {?RegExp}
      */
     asRegExp: function()
     {
         if (typeof this._regex !== "undefined")
             return this._regex;
         this._regex = null;
@@ skipping 465 matching lines @@
 
     _fireChangedIfNeeded: function()
     {
         var newValue = this._calculateValue();
         if (newValue === this._value)
             return;
         this._value = newValue;
         this._eventSupport.dispatchEventToListeners(this._name, this._value);
     }
 }