Issue 413213003: DevTools: Support Blackbox/Disabled options in framework blackboxing UI dialog.

Issue 413213003: DevTools: Support Blackbox/Disabled options in framework blackboxing UI dialog. (Closed)

Created:
6 years, 5 months ago by aandrey

Modified:
6 years, 4 months ago

Reviewers:
vsevik

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Support Blackbox/Disabled options in framework blackboxing UI dialog. BUG=267592 R=vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179035

Patch Set 1 #

Total comments: 6

Patch Set 2 : addressed #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -33 lines)			Patch
M	Source/devtools/front_end/common/Settings.js	View	1	5 chunks	+44 lines, -12 lines	0 comments	Download
M	Source/devtools/front_end/settings/FrameworkBlackboxDialog.js	View	1	5 chunks	+40 lines, -19 lines	0 comments	Download
M	Source/devtools/front_end/settings/SettingsScreen.js	View		3 chunks	+27 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

vsevik

lgtm https://chromiumcodereview.appspot.com/413213003/diff/1/Source/devtools/front_end/common/Settings.js File Source/devtools/front_end/common/Settings.js (right): https://chromiumcodereview.appspot.com/413213003/diff/1/Source/devtools/front_end/common/Settings.js#newcode240 Source/devtools/front_end/common/Settings.js:240: // Backward compatibility #1. Can we use WebInspector.VersionController ...

6 years, 4 months ago (2014-07-28 08:27:57 UTC) #2

aandrey

https://chromiumcodereview.appspot.com/413213003/diff/1/Source/devtools/front_end/common/Settings.js File Source/devtools/front_end/common/Settings.js (right): https://chromiumcodereview.appspot.com/413213003/diff/1/Source/devtools/front_end/common/Settings.js#newcode240 Source/devtools/front_end/common/Settings.js:240: // Backward compatibility #1. On 2014/07/28 08:27:57, vsevik wrote: ...

6 years, 4 months ago (2014-07-28 12:42:38 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/413213003/20001

6 years, 4 months ago (2014-07-28 12:44:33 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_compile_dbg on tryserver.blink ...

6 years, 4 months ago (2014-07-28 13:47:26 UTC) #6

Message was sent while issue was closed.

Change committed as 179035

Expand Messages | Collapse Messages