Fix for issue 19817

runtime/vm/debugger_api_impl.cc

Index: runtime/vm/debugger_api_impl.cc
===================================================================
--- runtime/vm/debugger_api_impl.cc	(revision 38463)
+++ runtime/vm/debugger_api_impl.cc	(working copy)
@@ -314,11 +314,6 @@
   DARTSCOPE(isolate);
   UNWRAP_AND_CHECK_PARAM(Function, function, function_in);
 
-  Dart_Handle state = Api::CheckIsolateState(isolate);
-  if (::Dart_IsError(state)) {
-    return state;
-  }
-
   const Class& cls = Class::Handle(function.origin());
   if (!cls.IsTopLevel()) {
     return Dart_NewInteger(cls.id());
@@ -343,11 +338,6 @@
   DARTSCOPE(isolate);
   UNWRAP_AND_CHECK_PARAM(String, script_url, script_url_in);
 
-  Dart_Handle state = Api::CheckIsolateState(isolate);
-  if (::Dart_IsError(state)) {
-    return state;
-  }
-
   Debugger* debugger = isolate->debugger();
   ASSERT(debugger != NULL);
   SourceBreakpoint* bpt =
@@ -400,11 +390,6 @@
   UNWRAP_AND_CHECK_PARAM(String, class_name, class_name_in);
   UNWRAP_AND_CHECK_PARAM(String, function_name, function_name_in);
 
-  Dart_Handle state = Api::CheckIsolateState(isolate);

[hausner, 2014/07/22 18:23:32]

Should we check that the library has been successfully loaded? If so, just add a
TODO and I'll add the check later.

[siva, 2014/07/22 19:55:11]

Added a check that the library passed in is loaded.

On 2014/07/22 18:23:32, hausner wrote:

-  if (::Dart_IsError(state)) {
-    return state;
-  }
-
   // Resolve the breakpoint target function.
   Debugger* debugger = isolate->debugger();
   const Function& bp_target = Function::Handle(
@@ -438,11 +423,6 @@
   UNWRAP_AND_CHECK_PARAM(String, class_name, class_name_in);
   UNWRAP_AND_CHECK_PARAM(String, function_name, function_name_in);
 
-  Dart_Handle state = Api::CheckIsolateState(isolate);

[hausner, 2014/07/22 18:23:32]

ditto

[siva, 2014/07/22 19:55:11]

Done.

-  if (::Dart_IsError(state)) {
-    return state;
-  }
-
   // Resolve the breakpoint target function.
   Debugger* debugger = isolate->debugger();
   const Function& bp_target = Function::Handle(