Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: chrome/browser/resources/sync_setup_overlay.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ugh just no Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/sync_setup_overlay.js
diff --git a/chrome/browser/resources/sync_setup_overlay.js b/chrome/browser/resources/sync_setup_overlay.js
index 8684734b8bdab5c75c6813d62350d58a815fc343..22bf0108fa58ac46bfe18aa0d4f411f3c9319cc4 100644
--- a/chrome/browser/resources/sync_setup_overlay.js
+++ b/chrome/browser/resources/sync_setup_overlay.js
@@ -3,7 +3,8 @@
// found in the LICENSE file.
cr.define('options', function() {
- /** @const */ var OptionsPage = options.OptionsPage;
+ /** @const */ var Page = cr.ui.pageManager.Page;
+ /** @const */ var PageManager = cr.ui.pageManager.PageManager;
// True if the synced account uses a custom passphrase.
var usePassphrase_ = false;
@@ -48,19 +49,19 @@ cr.define('options', function() {
* @class
*/
function SyncSetupOverlay() {
- OptionsPage.call(this, 'syncSetup',
- loadTimeData.getString('syncSetupOverlayTabTitle'),
- 'sync-setup-overlay');
+ Page.call(this, 'syncSetup',
+ loadTimeData.getString('syncSetupOverlayTabTitle'),
+ 'sync-setup-overlay');
}
cr.addSingletonGetter(SyncSetupOverlay);
SyncSetupOverlay.prototype = {
- __proto__: OptionsPage.prototype,
+ __proto__: Page.prototype,
/** @override */
initializePage: function() {
- OptionsPage.prototype.initializePage.call(this);
+ Page.prototype.initializePage.call(this);
var self = this;
$('basic-encryption-option').onchange =
@@ -89,7 +90,7 @@ cr.define('options', function() {
},
showOverlay_: function() {
- OptionsPage.navigateToPage('syncSetup');
+ PageManager.showPageByName('syncSetup');
},
closeOverlay_: function() {
@@ -98,7 +99,7 @@ cr.define('options', function() {
var overlay = $('sync-setup-overlay');
if (!overlay.hidden)
- OptionsPage.closeOverlay();
+ PageManager.closeOverlay();
},
/** @override */
@@ -718,7 +719,7 @@ cr.define('options', function() {
for (var i = 0; i < overlay.children.length; i++)
overlay.children[i].hidden = true;
- // Bypass OptionsPage.navigateToPage because it will call didShowPage
+ // Bypass PageManager.showPageByName because it will call didShowPage
// which will set its own visible page, based on the flow state.
this.visible = true;
« no previous file with comments | « chrome/browser/resources/options/website_settings.js ('k') | chrome/browser/ui/webui/options/manage_profile_browsertest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698