Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4283)

Unified Diff: chrome/browser/resources/options/settings_dialog.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ugh just no Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/settings_dialog.js
diff --git a/chrome/browser/resources/options/settings_dialog.js b/chrome/browser/resources/options/settings_dialog.js
index 7391b8695d31bb7a1572afc1e93bb9f00437908a..fb0d50985168a63a78d7078c2a128ac5946170f7 100644
--- a/chrome/browser/resources/options/settings_dialog.js
+++ b/chrome/browser/resources/options/settings_dialog.js
@@ -8,26 +8,27 @@
*/
cr.define('options', function() {
- /** @const */ var OptionsPage = options.OptionsPage;
+ /** @const */ var Page = cr.ui.pageManager.Page;
+ /** @const */ var PageManager = cr.ui.pageManager.PageManager;
/**
* Base class for settings dialogs.
* @constructor
- * @param {string} name See OptionsPage constructor.
- * @param {string} title See OptionsPage constructor.
- * @param {string} pageDivName See OptionsPage constructor.
+ * @param {string} name See Page constructor.
+ * @param {string} title See Page constructor.
+ * @param {string} pageDivName See Page constructor.
* @param {HTMLInputElement} okButton The confirmation button element.
* @param {HTMLInputElement} cancelButton The cancellation button element.
- * @extends {OptionsPage}
+ * @extends {Page}
*/
function SettingsDialog(name, title, pageDivName, okButton, cancelButton) {
- OptionsPage.call(this, name, title, pageDivName);
+ Page.call(this, name, title, pageDivName);
this.okButton = okButton;
this.cancelButton = cancelButton;
}
SettingsDialog.prototype = {
- __proto__: OptionsPage.prototype,
+ __proto__: Page.prototype,
/** @override */
initializePage: function() {
@@ -39,7 +40,7 @@ cr.define('options', function() {
* Handles the confirm button by saving the dialog preferences.
*/
handleConfirm: function() {
- OptionsPage.closeOverlay();
+ PageManager.closeOverlay();
var prefs = Preferences.getInstance();
var els = this.pageDiv.querySelectorAll('[dialog-pref]');
@@ -53,7 +54,7 @@ cr.define('options', function() {
* Handles the cancel button by closing the overlay.
*/
handleCancel: function() {
- OptionsPage.closeOverlay();
+ PageManager.closeOverlay();
var prefs = Preferences.getInstance();
var els = this.pageDiv.querySelectorAll('[dialog-pref]');
« no previous file with comments | « chrome/browser/resources/options/search_page.js ('k') | chrome/browser/resources/options/startup_overlay.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698