Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: chrome/browser/resources/options/password_manager.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ugh just no Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/password_manager.js
diff --git a/chrome/browser/resources/options/password_manager.js b/chrome/browser/resources/options/password_manager.js
index 36c04edc6040c216b7762ce1ef2262d18823c834..4758254538cf243d93e99601941836210b30514d 100644
--- a/chrome/browser/resources/options/password_manager.js
+++ b/chrome/browser/resources/options/password_manager.js
@@ -3,7 +3,8 @@
// found in the LICENSE file.
cr.define('options', function() {
- /** @const */ var OptionsPage = options.OptionsPage;
+ /** @const */ var Page = cr.ui.pageManager.Page;
+ /** @const */ var PageManager = cr.ui.pageManager.PageManager;
/** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
/////////////////////////////////////////////////////////////////////////////
@@ -15,16 +16,15 @@ cr.define('options', function() {
*/
function PasswordManager() {
this.activeNavTab = null;
- OptionsPage.call(this,
- 'passwords',
- loadTimeData.getString('passwordsPageTabTitle'),
- 'password-manager');
+ Page.call(this, 'passwords',
+ loadTimeData.getString('passwordsPageTabTitle'),
+ 'password-manager');
}
cr.addSingletonGetter(PasswordManager);
PasswordManager.prototype = {
- __proto__: OptionsPage.prototype,
+ __proto__: Page.prototype,
/**
* The saved passwords list.
@@ -56,10 +56,10 @@ cr.define('options', function() {
/** @override */
initializePage: function() {
- OptionsPage.prototype.initializePage.call(this);
+ Page.prototype.initializePage.call(this);
$('password-manager-confirm').onclick = function() {
- OptionsPage.closeOverlay();
+ PageManager.closeOverlay();
};
$('password-search-box').addEventListener('search',

Powered by Google App Engine
This is Rietveld 408576698