Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: chrome/browser/resources/options/language_dictionary_overlay.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ugh just no Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/language_dictionary_overlay.js
diff --git a/chrome/browser/resources/options/language_dictionary_overlay.js b/chrome/browser/resources/options/language_dictionary_overlay.js
index 0778fb1b88daf48771386aedbcd1f4774ed0a851..57d549e5a6f55199082d9ec37dbe669e38772472 100644
--- a/chrome/browser/resources/options/language_dictionary_overlay.js
+++ b/chrome/browser/resources/options/language_dictionary_overlay.js
@@ -5,23 +5,24 @@
cr.define('options', function() {
/** @const */ var DictionaryWordsList =
options.dictionary_words.DictionaryWordsList;
- /** @const */ var OptionsPage = options.OptionsPage;
+ /** @const */ var Page = cr.ui.pageManager.Page;
+ /** @const */ var PageManager = cr.ui.pageManager.PageManager;
/**
* Adding and removing words in custom spelling dictionary.
* @constructor
- * @extends {options.OptionsPage}
+ * @extends {cr.ui.pageManager.Page}
*/
function EditDictionaryOverlay() {
- OptionsPage.call(this, 'editDictionary',
- loadTimeData.getString('languageDictionaryOverlayPage'),
- 'language-dictionary-overlay-page');
+ Page.call(this, 'editDictionary',
+ loadTimeData.getString('languageDictionaryOverlayPage'),
+ 'language-dictionary-overlay-page');
}
cr.addSingletonGetter(EditDictionaryOverlay);
EditDictionaryOverlay.prototype = {
- __proto__: OptionsPage.prototype,
+ __proto__: Page.prototype,
/**
* A list of words in the dictionary.
@@ -46,7 +47,7 @@ cr.define('options', function() {
/** @override */
initializePage: function() {
- OptionsPage.prototype.initializePage.call(this);
+ Page.prototype.initializePage.call(this);
this.wordList_ = $('language-dictionary-overlay-word-list');
DictionaryWordsList.decorate(this.wordList_);
@@ -69,7 +70,7 @@ cr.define('options', function() {
'language-dictionary-overlay-no-matches');
$('language-dictionary-overlay-done-button').onclick = function(e) {
- OptionsPage.closeOverlay();
+ PageManager.closeOverlay();
};
},

Powered by Google App Engine
This is Rietveld 408576698